React query options braking changes starting from v5 about orval HOT 9 CLOSED

you now have a new option with the 5.3.0. You can add this option in the override to only have the queryOptions

from orval.

check this issue #115. Personally, I use 90% of the time the global config but that's not the case for everyone. A solution would be to add an option in the orval config for that but I have no idea how to name it 😀

from orval.

Great
+1 for this approach

from orval.

Depending of the endpoints you can already have multiple arguments (all params, query params, body). The query config is optional and always the last argument. If I don't do this breaking change we will be force to pass undefined to the query config argument to pass an axios config. Same if we do it the other way around. That way I thought that an object where you can pass all options will be a better fit and will also help if we want to add other feature later on.

from orval.

If you have an other idea or option I am really open to discuss about it

from orval.

Yeah, i get your point, but During my experience with react-query with Axios, I nearly find myself passing Axios config with hooks, and I usually use them globally to Axios instance such headers.
Not sure if its the same for you
so for me, I would prefer to make my custom query hook identic as a simple react-query hook (same API), and should be ok to pass query configs as undefined in case I want to add Axios config.

from orval.

Something like this? And if you set false we don't add the config globally or per operation.

from orval.

i think this should work, and we can make it false by default to prevent breaking changes 👍
we still can pass a custom Axios instance when httpConfig: false correct ?

from orval.

sure! You will just not have the possibility to pass a second argument to your custom instance

from orval.