Git Product home page Git Product logo

Comments (4)

kaby76 avatar kaby76 commented on June 1, 2024

It is unclear what it could be because the tester uses the latest available.

python-version: '3.x'
The plugin itself recommends setting an explicit version: (we recommend always setting Python version explicitly using the python-version or python-version-file inputs). In addition, to properly qualify a version range, you need to test each and every version in a range of versions in a test matrix in Github Actions workflow. In grammars-g4, I set the version explicitly to 3.10 because I had problems with version 3.8. https://github.com/antlr/grammars-v4/blob/153d66809d26425e5ac49cec77294f034d99eb0b/.github/workflows/main.yml#L113 However, that may be because some of the grammars have base class support code that relies on 3.10, and not with the generated parsers themselves. I don't test a range because it takes a long time to do this testing with each PR. And it can be expensive.

from antlr4.

gricey432 avatar gricey432 commented on June 1, 2024

Thanks for the response @kaby76, it's raised some further questions.

The plugin itself recommends setting an explicit version: (we recommend always setting Python version explicitly using the python-version or python-version-file inputs).

Where'd you find that line? The readme for the Python target doesn't seem to have that text in it and I'm unsure what a 'plugin' is in the ANTLR ecosystem. Also don't get any code matches on a Github search.

In addition, to properly qualify a version range, you need to test each and every version in a range of versions in a test matrix in Github Actions workflow. ... I don't test a range because it takes a long time to do this testing with each PR. And it can be expensive.

Hmm yeah having a look at the GitHub actions it looks like this repo is using one giant sequential job for the bulk of the Workflow. I feel like there'd be huge benefit in making a larger number of small jobs, but that's probably a different ticket.

The kind of code I'm proposing removal of (if 3.6 is minimum supported) is blocks like

if sys.version_info[1] > 5:

from antlr4.

kaby76 avatar kaby76 commented on June 1, 2024

Where'd you find that line?

Sorry, it is from https://github.com/actions/setup-python , the first big paragraph under "Basic usage".

Yes, validating the supported versions of a runtime environment is another problem. The change in the Antlr source code is also something that needs to be fixed with the correct value or removed.

from antlr4.

gricey432 avatar gricey432 commented on June 1, 2024

Sorry, it is from https://github.com/actions/setup-python , the first big paragraph under "Basic usage".

Ah I misunderstood; thought you were talking about ANTLR suggesting pinning Python.

from antlr4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.