Comments (5)
ericvergnaud
commented on June 7, 2024
Mmm... the target template should be generating them, see TypeScript.stg, line 875:
public static readonly channelNames: string[] = [ "DEFAULT_TOKEN_CHANNEL", "HIDDEN"<if (lexer.channelNames)>, <lexer.channelNames:{c| "<c>"}; separator=", ", wrap, anchor><endif> ];
from antlr4.
kaby76
commented on June 7, 2024
Sure, those are the names of the channels declared as an array of strings. But, if you look at the generated lexer for CSharp or probably Java, you also get constant declarations. So, when I want to reference the channel in base class code, like this in CSharp (https://github.com/antlr/grammars-v4/blob/c7883a594bf622200c561db181848d277fcd49a7/php/CSharp/PhpLexerBase.cs#L79), I can't in TypeScript (https://github.com/kaby76/grammars-v4/blob/865ccef278193e46e6cb285ea4df2a22480b7268/php/Antlr4ng/PhpLexerBase.ts#L48)--I have to hardwire the number. This is brittle code, and unnecessary.
from antlr4.
ericvergnaud
commented on June 7, 2024
Can you provide an example of the generated code ?
from antlr4.
kaby76
commented on June 7, 2024
php_lexer.go.txt
PhpLexer.cs.txt
PhpLexer.dart.txt
PhpLexer.g4.txt
PhpLexer.h.txt
PhpLexer.java.txt
PhpLexer.js.txt
PhpLexer.py.txt
PhpLexer.ts.txt
PhpLexer.php.txt
PhpLexer.swift.txt
(Files generated via antlr4 -Dlanguage=whatever PhpLexer.g4.)
The targets that have a constant defined for SkipChannel: Cpp, CSharp, Dart, Go, Java, JavaScript, PHP, Python3, Swift.
The targets missing a constant definition for SkipChannel: TypeScript.
$ grep SkipChannel *.txt | grep 4
php_lexer.go.txt: PhpLexerSkipChannel = 4
PhpLexer.cs.txt: PhpComments=2, ErrorLexem=3, SkipChannel=4;
PhpLexer.dart.txt: PhpComments = 2, ErrorLexem = 3, SkipChannel = 4;
PhpLexer.g4.txt: SkipChannel
PhpLexer.g4.txt:PHPStart : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartInside : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartInsideQuoteString : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartDoubleQuoteString : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartInsideScript : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:Whitespace : [ \t\r\n]+ -> channel(SkipChannel);
PhpLexer.g4.txt:SingleLineComment : '//' -> channel(SkipChannel), pushMode(SingleLineCommentMode);
PhpLexer.g4.txt:ShellStyleComment : '#' -> channel(SkipChannel), pushMode(SingleLineCommentMode);
PhpLexer.g4.txt: '{' { this.IsCurlyDollar(1) }? { this.SetInsideString(); } -> channel(SkipChannel), pushMode(PHP)
PhpLexer.g4.txt:CommentEnd : [\r\n] -> channel(SkipChannel), popMode; // exit from comment.
PhpLexer.h.txt: PhpComments = 2, ErrorLexem = 3, SkipChannel = 4
PhpLexer.java.txt: PhpComments=2, ErrorLexem=3, SkipChannel=4;
PhpLexer.js.txt:PhpLexer.SkipChannel = 4;
PhpLexer.php.txt: public const PhpComments = 2, ErrorLexem = 3, SkipChannel = 4;
PhpLexer.py.txt: SkipChannel = 4
PhpLexer.swift.txt: static let PhpComments=2, ErrorLexem=3, SkipChannel=4
from antlr4.
ericvergnaud
commented on June 7, 2024
Noted, thanks!
… Le 2 avr. 2024 à 00:46, Ken Domino ***@***.***> a écrit :
php_lexer.go.txt <https://github.com/antlr/antlr4/files/14829164/php_lexer.go.txt>
PhpLexer.cs.txt <https://github.com/antlr/antlr4/files/14829165/PhpLexer.cs.txt>
PhpLexer.dart.txt <https://github.com/antlr/antlr4/files/14829166/PhpLexer.dart.txt>
PhpLexer.g4.txt <https://github.com/antlr/antlr4/files/14829167/PhpLexer.g4.txt>
PhpLexer.h.txt <https://github.com/antlr/antlr4/files/14829168/PhpLexer.h.txt>
PhpLexer.java.txt <https://github.com/antlr/antlr4/files/14829169/PhpLexer.java.txt>
PhpLexer.js.txt <https://github.com/antlr/antlr4/files/14829170/PhpLexer.js.txt>
PhpLexer.py.txt <https://github.com/antlr/antlr4/files/14829171/PhpLexer.py.txt>
PhpLexer.ts.txt <https://github.com/antlr/antlr4/files/14829172/PhpLexer.ts.txt>
PhpLexer.php.txt <https://github.com/antlr/antlr4/files/14829202/PhpLexer.php.txt>
PhpLexer.swift.txt <https://github.com/antlr/antlr4/files/14829207/PhpLexer.swift.txt>
(Files generated via antlr4 -Dlanguage=whatever PhpLexer.g4.)
The targets that have a constant defined for SkipChannel: Cpp, CSharp, Dart, Go, Java, JavaScript, PHP, Python3, Swift.
The targets missing a constant definition for SkipChannel: TypeScript.
$ grep SkipChannel *.txt | grep 4
php_lexer.go.txt: PhpLexerSkipChannel = 4
PhpLexer.cs.txt: PhpComments=2, ErrorLexem=3, SkipChannel=4;
PhpLexer.dart.txt: PhpComments = 2, ErrorLexem = 3, SkipChannel = 4;
PhpLexer.g4.txt: SkipChannel
PhpLexer.g4.txt:PHPStart : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartInside : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartInsideQuoteString : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartDoubleQuoteString : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:PHPStartInsideScript : PhpStartFragment -> channel(SkipChannel), pushMode(PHP);
PhpLexer.g4.txt:Whitespace : [ \t\r\n]+ -> channel(SkipChannel);
PhpLexer.g4.txt:SingleLineComment : '//' -> channel(SkipChannel), pushMode(SingleLineCommentMode);
PhpLexer.g4.txt:ShellStyleComment : '#' -> channel(SkipChannel), pushMode(SingleLineCommentMode);
PhpLexer.g4.txt: '{' { this.IsCurlyDollar(1) }? { this.SetInsideString(); } -> channel(SkipChannel), pushMode(PHP)
PhpLexer.g4.txt:CommentEnd : [\r\n] -> channel(SkipChannel), popMode; // exit from comment.
PhpLexer.h.txt: PhpComments = 2, ErrorLexem = 3, SkipChannel = 4
PhpLexer.java.txt: PhpComments=2, ErrorLexem=3, SkipChannel=4;
PhpLexer.js.txt:PhpLexer.SkipChannel = 4;
PhpLexer.php.txt: public const PhpComments = 2, ErrorLexem = 3, SkipChannel = 4;
PhpLexer.py.txt: SkipChannel = 4
PhpLexer.swift.txt: static let PhpComments=2, ErrorLexem=3, SkipChannel=4
—
Reply to this email directly, view it on GitHub <#4572 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJAJN7Z5W6GV2M3UOVLY3HPUFAVCNFSM6AAAAABFRND5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQG4YDKMRXHA>.
You are receiving this because you commented.
from antlr4.
Related Issues (20)
- Creates parser that uses wrong fieldname when referencing field causing CS1001 HOT 1
- JavaScript runtime: could the transition classes be exported? HOT 11
- ANTLR not recognizing label assignment HOT 11
- Segmentation fault on C++ runtime in SingletonPredictionContext HOT 5
- Is Java Lexer ATN Serialization explosion expected since 4.7.2? HOT 7
- Using antlr4 go to parse SQL takes too much time HOT 21
- The altNum displayed in the ANTLR4 plugin tool differs from the altNum at runtime.
- antlr4-go out-of-date HOT 4
- How to get parent of the node using antlr4 typescript HOT 5
- Usage of `\p{Alpha}` does not work as expected on earlier versions of JDK 17
- ATN.NextToken(state) should be memoized HOT 3
- PL/SQL grammar cannot recognise identifiers that start with keywords HOT 2
- Migration bug in golang runtime HOT 5
- Could not deserialize ATN with version 3 (expected 4) with Hibernate 6 HOT 3
- Generate an abstract class/interface for rule containing only other parser rules as unnamed subrules
- [Swift] Add privacy manifest HOT 2
- [Go] Type signature error HOT 1
- How can we write multiple parsers to use the same lexer? HOT 1
- [CSharp] Member GetMaxTokenType missing in IVocabulary
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from antlr4.