Allow for custom endpoints about amazons3requestmanager HOT 8 CLOSED

@sbhklr That's a great point. Due to some changes with V4Signatures (#17), we actually need to have multiple values that are being determined by the region. The endpoint and the name of the region are both used now. This complicates things just a little. You can see the feature/AWS_signature_v4 branch to see what I'm talking about.

Let me look more closely at what I'm doing there and we can discuss what the best solution to this is.

from amazons3requestmanager.

I see. I'm thinking about an elegant solution. Looks like enums aren't really suited for injecting custom values.

from amazons3requestmanager.

Not true, you can use associated values on an enum case. The most elegant way to do this would probably be to create a new region enum case Custom with associated values for the endpoint and name.

from amazons3requestmanager.

Alright, I didn't know. That's indeed a pretty elegant solution.

from amazons3requestmanager.

Hmm, looks like we cannot mix enum cases with raw values and associated values.

from amazons3requestmanager.

Ah, that's right. Didn't think about that. I should be able to fix this by removing the raw values from the enum. We don't really need them. I'll get that done tomorrow!

from amazons3requestmanager.

Okay, I've removed the raw values from the enum case on develop. Next step is to add the custom region case.

from amazons3requestmanager.

This has been implemented in version 0.12.0

from amazons3requestmanager.