Git Product home page Git Product logo

Comments (3)

RobPasMue avatar RobPasMue commented on July 19, 2024 1

This could be a classmethod. Plan on implementing this @Revathyvenugopal162 whenever you have time. Sounds useful.

from pyansys-geometry.

chadqueen avatar chadqueen commented on July 19, 2024

Note the implementation added to the arc constructor last week to address a bug in the arc. Encapsulating this would be helpful.

self._center, self._start, self._end = center, start, end
self._axis = axis

to_start_vector = QuantityVector.from_points(self._start, self._center)
self._radius = to_start_vector.norm

if not self._radius.m > 0:
    raise ValueError("Point configuration does not yield a positive length arc radius.")

direction_x = UnitVector(to_start_vector.normalize())
direction_y = UnitVector((axis % direction_x).normalize())
to_end_vector = UnitVector.from_points(self._end, self._center)
self._angle = np.arctan2(direction_y * to_end_vector, direction_x * to_end_vector)
if self._angle < 0:
    self._angle = (2 * np.pi) + self._angle

from pyansys-geometry.

RobPasMue avatar RobPasMue commented on July 19, 2024

This was already implemented on my side during PR #156

Closing issue.

from pyansys-geometry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.