Git Product home page Git Product logo

Comments (4)

beeankha avatar beeankha commented on August 26, 2024

Some more notes:

  • ONLY for the build command, we need a -t --tag flag (this names the container)
  • After create gets called, there should be a path for the build context
  • The build command needs to call docker build -f Containerfile .
  • Need a --container-runtime flag in order to specify either Docker or Podman builds (defaulting to Podman)
  • Implement a unit test that asserts that command contains certain elements, whether or not we override things like the build context path or the tag (from #16 (comment))

from ansible-builder.

beeankha avatar beeankha commented on August 26, 2024
  • A visual "spinner" and/or stdout print in real-time would be nice while container is being built, etc.

Better Documentation:

  • Need to have a paragraph come up when running ansible-builder -h that explains what Builder is/does
  • Need to update the docstrings for the create and build commands to be more specific/helpful for the user

from ansible-builder.

AlanCoding avatar AlanCoding commented on August 26, 2024

Can we combine or close some of these, and just say "document and test the basic feature set"? @kdelee

from ansible-builder.

kdelee avatar kdelee commented on August 26, 2024

I've tried out these commands and I think we can close this and yes, we need to write up a set of basic test cases we want to implement but that does not have to block closing this issue.

from ansible-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.