Git Product home page Git Product logo

Comments (7)

anseki avatar anseki commented on June 3, 2024

Hi @calumk, thank you for the comment.
To begin with, the insProps was implemented to avoid accessing via API. That is, the properties are private fields in old ECMAScript. In other words, the insProps is not required if those are accessible, and those should be moved to instance properties.
Therefore, your plan means breaking the API design above obviously. And also, that should make more problems.
If you really want to do that, you can fork and customize the library to make a special one for your app. Or, you had better use another great library instead. The LeaderLine is inappropriate for your app maybe.

from leader-line.

calumk avatar calumk commented on June 3, 2024

Is there some way you could consider modifying the API, such that it is possible to access the SVG, by accessing the line object, without breaking the api.
I dont really mind how it exposes it, but access to the rendered SVG, from the PlainDraggable object, seems like a good idea?

For now i have forked the project

from leader-line.

anseki avatar anseki commented on June 3, 2024

Sorry, my English is poor.
Do you mean that you want to use LeaderLine with PlainDraggable and you can't do that?

from leader-line.

calumk avatar calumk commented on June 3, 2024

Sorry - Typo

I dont really mind how it exposes it, but access to the rendered SVG, from the [LeaderLine] object, seems like a good idea?

from leader-line.

anseki avatar anseki commented on June 3, 2024

No, that is not good idea.
You should not change the code if you can't understand why the insProps exists.
You had better use another great library instead. The LeaderLine is inappropriate for your app. You maybe need a library as helper for handling SVG, the LeaderLine is not.

from leader-line.

calumk avatar calumk commented on June 3, 2024

I have used leader-line extensivly over the last few years - So i disagree that it is inappropriate, but it is your library, your choice.

https://www.youtube.com/watch?v=OBI3qEEFtBg&feature=youtu.be

from leader-line.

anseki avatar anseki commented on June 3, 2024

You may understand that when you learn the ECMAScript.
πŸ˜„

from leader-line.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.