Git Product home page Git Product logo

Comments (6)

pravincar avatar pravincar commented on September 8, 2024

@andrewhaighcell I had created the PR to add the optional enableAsyncReads parameter without realizing that this driver is also instantiated via reflection. Adding a new constructor seems like the best way forward. Can you open a PR with your change?

from usbserialforandroid.

andrewhaighcell avatar andrewhaighcell commented on September 8, 2024

I will try and sort that out over the weekend yes.

Thanks,
Andrew Haigh

from usbserialforandroid.

andrewhaighcell avatar andrewhaighcell commented on September 8, 2024

PR now raised here: #27

from usbserialforandroid.

andrewhaighcell avatar andrewhaighcell commented on September 8, 2024

@pravincar Hi, its not urgent but perhaps you would like to roll this change into the mainline? Thanks!

from usbserialforandroid.

andrewhaighcell avatar andrewhaighcell commented on September 8, 2024

Maybe @anotherlab might pull this in? Thanks!

from usbserialforandroid.

andrewhaighcell avatar andrewhaighcell commented on September 8, 2024

My fix has now been merged so this can be closed.

from usbserialforandroid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.