People were questioning whether the "total length of all submissions" calculation was

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

So it turns out that MutagenFile inherits from <a hre

The total song length calculation incorrectly skips over some songs about busty HOT 2 CLOSED

anoadragon453 commented on August 18, 2024

The total song length calculation incorrectly skips over some songs

from busty.

Comments (2)

anoadragon453 commented on August 18, 2024

@Cephian noticed that if we aren't able to read the length of a song, we just skip calculating it:

busty/src/song_utils.py

Lines 115 to 126 in e24df5f

 # Get length of a song 

 def get_song_length(filename: str) -> Optional[float]: 

 try: 

 audio = MutagenFile(filename) 

 if audio: 

 return audio.info.length 

 except MutagenError as e: 

 # Ignore file and move on 

 print(f"Error reading length of {filename}:", e) 

 except Exception as e: 

 print(f"Unknown error reading length of {filename}:", e) 

 return None

Next steps would be to go through all of the songs in Busty's 22 and see if the bot fails to read the length of any of them.

from busty.

anoadragon453 commented on August 18, 2024

So it turns out that MutagenFile inherits from DictMixin, which means that a fully-populated MutagenFile may resolve to {}.

Hence our if audio conditional in the code above can translate to if {}, which resolves to False... even if audio contains file information. The solution is to check whether audio is explicitly None, instead of just falsey.

from busty.

The total song length calculation incorrectly skips over some songs about busty HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# Get length of a song
	def get_song_length(filename: str) -> Optional[float]:
	try:
	audio = MutagenFile(filename)
	if audio:
	return audio.info.length
	except MutagenError as e:
	# Ignore file and move on
	print(f"Error reading length of {filename}:", e)
	except Exception as e:
	print(f"Unknown error reading length of {filename}:", e)
	return None