Git Product home page Git Product logo

Comments (7)

dobefore avatar dobefore commented on May 19, 2024

Hi,@JACK-THINK ,Thanks for the report.You are right.

Hello,@redmie ,I can not think up a better way to fix this and what I only do is use hard-code dir ,Do you have some ideas?

from anki-sync-server-rs.

redmie avatar redmie commented on May 19, 2024

Just checked out the code @dobefore, configuration file is not loaded ever. So no need to hard code paths, that's not the problem.
I'm really not happy with the way the configuration system works right now and want to fix it.
Please assign this issue to me I will rework this part before next Friday.

I *will change configuration file format to fix typos in configuration and allow its serialization and de-serialization.
I want to change the name of the config file to something that will allow one to find the software it is related to.
In the installation guide here you can see that I named it ankisyncd.toml.

As you can see @JACK-THINK it still alpha quality (and i'm still not running it at home (else I would have caught it sooner), I'm waiting for the internal logic and bugs to be ironed out first).

from anki-sync-server-rs.

dobefore avatar dobefore commented on May 19, 2024

@redmie ,THanks for the reply!looking forward to your contribution!

Acatually the application reads root folder(default to the same dir as the executable) from configure file.

Will it possible that the default configure file path is set to the same path as the executable? I just wondering this can be convienient for users who use it on windows

from anki-sync-server-rs.

redmie avatar redmie commented on May 19, 2024

This hopefully will be solved by #35.

Note that the configuration file will change (but you can see the defaults by calling the server with --defaults) and be incompatible with the current one.

from anki-sync-server-rs.

dobefore avatar dobefore commented on May 19, 2024

Hi, @JACK-THINK.
Due to @redmie 's wonderful efforts,bug apears to be fixed!releases 0.1.8 is available !

After that,creating user from config file is currently impossible,which maybe return back.

So you can use command user more see README.If you would like to load configuration not from the same path as ankisyncd ,you may need to move auth.db to that path.

feel free to reopen.

from anki-sync-server-rs.

redmie avatar redmie commented on May 19, 2024

I think making user/password available in config file is bad design security wise. Even in terms of usability what happens if you change the username in the config file? what if you change the password? There is so many strange corner cases possible that we should avoid that altogether.

One can simply add user to database using command and script it if automation is required.

from anki-sync-server-rs.

dobefore avatar dobefore commented on May 19, 2024

Sound reasonable! sorry for my less of consideration.So we will no longer make user/password available in config file

from anki-sync-server-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.