Win32 build failing due to libdav1d about ffmpeg-stable-autobuild HOT 4 CLOSED

@Vangelis66

Apologies if my query appears dumb

No, any attempts to gain knowledge is definitely not dumb. 😉

but wouldn't a more "elegant''' solution be that the config option --enable-libdav1d be simply commented out in the original ./config, so that the resultant binaries contain absolutely no mention of libdav1d ?

True, I should have just removed the --enable-libdav1d line on this and created a logic like:

if [[ $ffmpeg_git_checkout_version == "master" ]]; then
 config_options+=" --enable-libdav1d"
fi

Well, it seems like I blindly followed rdp's commit just to fix that failing libdav1d on stable builds. 😜

But hopefully, the upstream will fix this so that we can build libdav1d on FFmpeg stable builds again.

from ffmpeg-stable-autobuild.

Needed to disable libdav1d as dav1d has diverged. Already disabled on 64 bit, but still enabled on 32 bit n4.4 builds.

from ffmpeg-stable-autobuild.

Fixed on rdp/ffmpeg-windows-build-helpers#593 1fe8dfb

from ffmpeg-stable-autobuild.

Apologies if my query appears dumb 😉 , but...

rdp/ffmpeg-windows-build-helpers#593
-- Disable libdav1d on stable builds including 32 bit builds --

rdp/ffmpeg-windows-build-helpers@41b966a
-- Disable libdav1d on stable builds including 32 bit builds --

1fe8dfb =>

rdp/ffmpeg-windows-build-helpers@1289748
-- Disable libdav1d on stable releases --

I downloaded your latest stable 32-bit offering from

https://github.com/AnimMouse/ffmpeg-stable-autobuild/releases/tag/m-2021-10-19-18-00

yet

ffmpeg -hide_banner -buildconf | findstr libdav1d => 

    --enable-libdav1d
    --disable-libdav1d

I realise the net effect of enable+disable is that libdav1d isn't compiled in the end, but wouldn't a more "elegant" solution be that the config option --enable-libdav1d be simply commented out in the original ./config, so that the resultant binaries contain absolutely no mention of libdav1d ?

I admit at first I foolishly missed 😊 the --disable-libdav1d flag in FFmpeg's banner, because it appears towards the very end of that long configuration string, while my eyes had focused, out of habit 😜, on the --enable-libdav1d flag that appears at the same spot as in previous ffmpeg builds with that lib built-in...

Once more, many thanks for the great service you're providing to the FFmpeg user communities! 👍

from ffmpeg-stable-autobuild.