Git Product home page Git Product logo

Comments (9)

sjelin avatar sjelin commented on May 19, 2024 7

Hopefully!

from protractor-accessibility-plugin.

evilaliv3 avatar evilaliv3 commented on May 19, 2024 2

Done ;)

Would it be possible to have soon a release including this?

from protractor-accessibility-plugin.

lawlesscreation avatar lawlesscreation commented on May 19, 2024 1

Quite an old thread and I'm not sure how protractor accessibility plugin is being maintained but this is a bit of a blocker for our team.

We're getting false positives as the new ARIA 1.1 features (added to axe-core 2.4.0 GoogleChrome/lighthouse#3282) are not supported by the current dependencies of protractor accessibility plugin.

It seems if we manually update the axe-webdriverjs package to 0.5.0 it fixes this issue.

The really odd thing is, I don't understand why NPM doesn't download 0.5.0 anyway? It should get the latest minor version looking at the package.json but for some reason it's not.

"axe-webdriverjs": "^0.2.0"

from protractor-accessibility-plugin.

sjelin avatar sjelin commented on May 19, 2024

Yeah send us a PR

from protractor-accessibility-plugin.

evilaliv3 avatar evilaliv3 commented on May 19, 2024

@sjelin i was about to implement the patch and retesting if it work without changes or requires some adaptation but it seems that the tests are not working already in the current master.

could you please recheck?

i've tested running npm test but i'm getting:

evilaliv3@remotehost:~/Devel/clean/protractor-accessibility-plugin$ npm test

> [email protected] test /home/evilaliv3/Devel/clean/protractor-accessibility-plugin
> node test.js

running: node node_modules/protractor/bin/protractor spec/successConfig.js
[09:48:40] I/launcher - Running 1 instances of WebDriver
[09:48:40] I/hosted - Using the selenium server at http://localhost:4444/wd/hub
[09:48:40] E/launcher - Error code: 135
[09:48:40] E/launcher - Error message: ECONNREFUSED connect ECONNREFUSED 127.0.0.1:4444
[09:48:40] E/launcher - Error: ECONNREFUSED connect ECONNREFUSED 127.0.0.1:4444
    at ClientRequest.<anonymous> (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/http/index.js:238:15)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:310:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1278:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
From: Task: WebDriver.createSession()
    at Function.createSession (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/lib/webdriver.js:777:24)
    at Function.createSession (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/chrome.js:709:29)
    at createDriver (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/index.js:167:33)
    at Builder.build (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/index.js:623:16)
    at Hosted.getNewDriver (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/protractor/lib/driverProviders/driverProvider.ts:60:29)
    at Runner.createBrowser (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/protractor/lib/runner.ts:225:39)
    at q.then.then (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/protractor/lib/runner.ts:391:27)
    at _fulfilled (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/q/q.js:796:13)
[09:48:40] E/launcher - Process exited with error code 135
>>> fail: Error: expecting exit code: 0, actual: 135
running: node node_modules/protractor/bin/protractor spec/failureConfig.js
[09:48:41] I/launcher - Running 1 instances of WebDriver
[09:48:41] I/hosted - Using the selenium server at http://localhost:4444/wd/hub
[09:48:41] E/launcher - Error code: 135
[09:48:41] E/launcher - Error message: ECONNREFUSED connect ECONNREFUSED 127.0.0.1:4444
[09:48:41] E/launcher - Error: ECONNREFUSED connect ECONNREFUSED 127.0.0.1:4444
    at ClientRequest.<anonymous> (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/http/index.js:238:15)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:310:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1278:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
From: Task: WebDriver.createSession()
    at Function.createSession (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/lib/webdriver.js:777:24)
    at Function.createSession (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/chrome.js:709:29)
    at createDriver (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/index.js:167:33)
    at Builder.build (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/selenium-webdriver/index.js:623:16)
    at Hosted.getNewDriver (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/protractor/lib/driverProviders/driverProvider.ts:60:29)
    at Runner.createBrowser (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/protractor/lib/runner.ts:225:39)
    at q.then.then (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/protractor/lib/runner.ts:391:27)
    at _fulfilled (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/home/evilaliv3/Devel/clean/protractor-accessibility-plugin/node_modules/q/q.js:796:13)
[09:48:41] E/launcher - Process exited with error code 135
>>> fail: Error: expecting exit code: 1, actual: 135
Summary: fail
npm ERR! Test failed.  See above for more details.

from protractor-accessibility-plugin.

sjelin avatar sjelin commented on May 19, 2024

I actually cannot check that, as I don't have access to my dev machine at the moment. It looks like Protractor can't find the selenium sever though. Are you booting up webdriver-manager?

from protractor-accessibility-plugin.

evilaliv3 avatar evilaliv3 commented on May 19, 2024

You are actually right, i was missing that. sorry for the issues.

Just tested the update and tests passes.

Going to make a pull requests.

from protractor-accessibility-plugin.

evilaliv3 avatar evilaliv3 commented on May 19, 2024

it's a long way to the top if you wanna rock 'n' roll!

from protractor-accessibility-plugin.

mfrankwork avatar mfrankwork commented on May 19, 2024

Thanks for addressing the axe-webdriverjs update. Is there any news on when this will make it into a release?

from protractor-accessibility-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.