Use "pure-module" flag from package.json to opt modules into the more aggressive build optimization process about devkit HOT 3 CLOSED

On Thu, Aug 10, 2017 at 1:59 AM Filipe Silva ***@***.***> wrote: For reference: https://github.com/webpack/webpack/tree/feature/pure-module/examples/pure-module Doing this on the build-optimizer itself raises some problems. Build optimizer doesn't know about modules, and it actually doesn't know about file systems either. It only knows about file contents and (if given) file paths. And this is relevant in a webpack context because the file contents for a given file path may or may not be related to that path on disk. For instance, the file may have been through some loaders already and it's current content changed, or the given file path may not even exist at all (this happens for AOT code). The one that truly is aware of the pure-module flag is the system that is resolving the module - webpack in this case, maybe others in the future. So my suggestion is that we pass that information along in the build-optimizer call in the consumer: const boOutput = buildOptimizer({ content: input, pure: true }); This way the module loader can tell build optimizer that it thinks this given module is pure, and build optimizer itself drops the whitelist and doesn't even bother checking the file path, which was a problematic way to detect these anyway. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6GFX1-l7YnWy9knSfXi1GlB4Xl_Nks5sWsZVgaJpZM4Oyw9d> .