Purify should annotate the top level function call before parenthesis. about devkit HOT 7 CLOSED

/cc @IgorMinar

from devkit.

@mhevery is this transformation happening with @angular-devkit/build-optimizer?

I tried feeding it

export const Injectable = (/**@type{InjectableDecortaro}*/makeDecorator('Injectable'));

and it outputs

export const Injectable = /*@__PURE__*/ (makeDecorator('Injectable'));

Which seems to be what you want.

from devkit.

from devkit.

We did some upgrades to build-optimizer last week, could those have fixed this?

from devkit.

I tried finding it in AIO, by running ng build --environment=stable -aot -bo --no-sourcemap and searching dist/main.bundle.js for (/*@__PURE__*/ but could not find with the comment only inside the parenthesis.

I found a few with comment inside and outside though:

var reflector = /*@__PURE__*/ new Reflector(/*@__PURE__*/ new ReflectionCapabilities());

var _MdButtonMixinBase = /*@__PURE__*/ mixinColor(/*@__PURE__*/ mixinDisabled(MdButtonBase));

var _MdCheckboxMixinBase = /*@__PURE__*/ mixinColor(/*@__PURE__*/ mixinDisabled(MdCheckboxBase), 'accent');

    'yMMMdjms': /*@__PURE__*/ datePartGetterFactory(/*@__PURE__*/ combine([
        /*@__PURE__*/ digitCondition('year', 1),
        /*@__PURE__*/ nameCondition('month', 3),
        /*@__PURE__*/ digitCondition('day', 1),
        /*@__PURE__*/ digitCondition('hour', 1),
        /*@__PURE__*/ digitCondition('minute', 1),
        /*@__PURE__*/ digitCondition('second', 1),
    ])),

from devkit.

@filipesilva that's correct. nested calls should have the annotation at each level of nesting.

from devkit.

Misko removed the problematic casts in angular/angular@b7a6f52, so we shouldn't expect to see anything in the outputs. That said, when I re-add some of the original code causing issues, I see this now:

var Injectable = /*@__PURE__*/ (makeDecorator('Injectable'));

Seems like it's fixed. We can probably close this and re-open if we see it pop up again.

from devkit.