Comments (5)
filipesilva
commented on July 17, 2024
It should, yes. Thank you for the report and repro. Will investigate.
from devkit.
filipesilva
commented on July 17, 2024
Ok I know what's going on. The transform that adds that pure comment is prefix-functions.
But we only apply it to libraries we know are safe: https://github.com/angular/devkit/blob/master/packages/angular_devkit/build_optimizer/src/build-optimizer/build-optimizer.ts#L80-L92
So your user code does not get it. Perhaps we should have a flag to force it...
from devkit.
clydin
commented on July 17, 2024
Something else to note is that the annotation is only relevant if the component is never used within the application.
from devkit.
hansl
commented on July 17, 2024
@clydin @filipesilva Was this fixed by my fix from yesterday?
from devkit.
filipesilva
commented on July 17, 2024
@hansl no, this is different. It needs a forced flag. I'm putting up a PR for it soon.
from devkit.
Related Issues (20)
- How to use AngularCompilerPlugin to bundle stand-alone modules? HOT 1
- Inconsistency in ng new HOT 1
- Cannot handle async resource. angularCompilerOptions.enableResourceInlining requires all resources to be statically resolvable. HOT 4
- Reference to unpublished version of `[email protected]` in `build-angular@master`
- How to override files with merge or branchMerge? HOT 1
- SchematicTestRunner.callRule does not use the logger by default HOT 1
- BuildOptimizer breaks 3rd party library HOT 5
- Follow @angular/* versions HOT 1
- cli commands (`add`, `update`) remove empty lines from `package.json` HOT 1
- Invalid typing for webpack rules (changed from wp 3 > 4) HOT 5
- ng run --help not working HOT 2
- ng update @angular/cli => Error: connect ETIMEDOUT 151.101.12.162:80 HOT 1
- Incorrect declaration files HOT 5
- Make DevServerBuilder extensible HOT 3
- new webpack config is breaking 3rd party modules HOT 1
- generated apps with wrong baseUrl as TS config --> unable to compile lazyLoaded modules HOT 1
- ng lint broken HOT 1
- How configure SSR without CLI ? HOT 1
- baseHref/deployUrl option for universal build in @angular-devkit/build-angular:server HOT 1
- configure angular build dependecnies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devkit.