Git Product home page Git Product logo

Comments (9)

JoostK avatar JoostK commented on May 16, 2024 1

Interesting, this should work as we do parse this as math namespace, but then fail to validate it correctly.

from angular.

JeanMeche avatar JeanMeche commented on May 16, 2024 1

Yeah the compiler output clearly has the MathML support in it.

The DomRenderer relies on createElementNS() but it looks like the namespace is wrong.

'math': 'http://www.w3.org/1998/MathML/',

It should be http://www.w3.org/1998/Math/MathML per this

from angular.

JeanMeche avatar JeanMeche commented on May 16, 2024 1

With #55622 we'll at least get the support for MathML but it will still require NO_ERRORS_SCHEMA .

from angular.

JeanMeche avatar JeanMeche commented on May 16, 2024 1

@lukewarlow Yes, we're looking at landing this "fix" into 17.3 and the upcomming 18.0 !

from angular.

lukewarlow avatar lukewarlow commented on May 16, 2024

Intersting, this should work as we do parse this as math namespace, but then fail to validate it correctly.

Yeah, there's definitely some level of support for it, the namespace appears correct but then it seems to get the prototype wrong (not even sure how that's possible?). As a guess it's not using createElementNS(), it's doing something else.

from angular.

JoostK avatar JoostK commented on May 16, 2024

With #55622 we'll at least get the support for MathML but it will still require NO_ERRORS_SCHEMA .

Yeah that error is because DomSchemaChecker is looking up the definition using the prefixed tagname :math:math which isn't present, as it only contains non-prefixed tagnames.

We should ideally have a branded type for those prefixed tag names, that will likely expose some inconsistencies.

from angular.

lukewarlow avatar lukewarlow commented on May 16, 2024

@JeanMeche great catch! I was just helping someone else with a similar issue where createElementNS was returning an Element and it was an invalid namespace which brought me back here, you're one step ahead though

from angular.

lukewarlow avatar lukewarlow commented on May 16, 2024

Would be good to reopen this issue until #55622 is merged (or go ahead and merge that as it's approved)

from angular.

lukewarlow avatar lukewarlow commented on May 16, 2024

Closing this now that the second PR has been merged.

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.