Comments (5)
Have already created branch to fix it:
http://github.com/vojtajina/angular.js/tree/fix-url-matcher
from angular.js.
let me know when it is ready for review and integration.
from angular.js.
is this: http://www.angularjs.org#xx a valid URI? we should check the RFC before we support it.
+1 on testing the regexp separately
from angular.js.
Thanks for note about RFC, I didn't think about it...
You can check RFC, they say:
An HTTP URL takes the form:
http:// <host> : <port> / <path> ? <searchpart>
where <host> and <port> are as described in Section 3.1. If :<port>
is omitted, the port defaults to 80. No user name or password is
allowed. <path> is an HTTP selector, and <searchpart> is a query
string. The <path> is optional, as is the <searchpart> and its
preceding "?". If neither <path> nor <searchpart> is present, the "/"
may also be omitted.
So, that means http://www.server.com is a valid url, but you are right, it's always good to add the forward slash.
Important thing is, that URL_MATCH is parser, not validator !
According to the rfc specification, "/" is not part of the path ! But check the javascript object window.location, at least in Firefox: "/" is part of the path property...
It's easy to change the regexp, that "/" would not be part of the url, but I would prefer to keep current behavior...
Well, I hope this patch is ready, the issue is fixed, whole branch is rebased to one commit.
Anyway, it would be good to add some more tests, consider adding more protocols (currently just http, https, ftp, file), etc...
from angular.js.
fixed via #68
from angular.js.
Related Issues (20)
- Não consigo instalar angular, o node já instalei HOT 2
- erro ao criar um projeto no angular HOT 1
- angular-orianat issue HOT 1
- cant understand why this error occurs in angularjs PHP JSON. This is my error HOT 2
- cant understand why $http:Baddata occur in angularjs php and json. HOT 3
- jjkzh;[\., .]/'ng .;lpk[jk]
- jjkzh;[\., .]/'ng .;lpk[jk]';'
- Touch and Hold on the link cannot bring up context menu HOT 3
- Why not just include the gtag script in your header? HOT 3
- docs: fix the docs to be CommonMark compliant
- Transition Rejection : while upgrading angularjs from 1.5 to 1.8 HOT 1
- ngOptions removeUnknownOption() doesn't work right in mobile browsers HOT 2
- so long
- Angular.Js
- AngularJs
- Vulnerable libraries angular JavaScript angular.js 1.5.3 SNYK-npm HOT 4
- ngChange handler called, on submit, for blank type="number" fields, when they haven't changed
- what correct typing for $sanitize?
- AngularJs 1.7.0 Upgrade Issue. HOT 1
- []
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular.js.