Providing missingTranslationHandler() same flexibility as useStorage() about angular-translate HOT 10 CLOSED

1. What about a chain/list of handlers?
2. What about a similar list of handlers for success? Currently, this is a $rootScope broadcast.

from angular-translate.

For example?

from angular-translate.

Example for what? :)

from angular-translate.

It'd be great to get more details on what you've posted.

from angular-translate.

Just brainstorming.

1. Instead of one single failure handler, it could be list of handlers.
Reason 1: Currently we cannot use our own failure handler (apart from simple $log) because of same reasons like success (see down). Reason 2: Currently different independent handlers must be implemented in one single.

We can add another api or just extend this one to be optional adding (default replace just like before)

  this.missingTranslationHandler = function (functionHandler, noReplace) {
    if (angular.isUndefined(noReplace) || !noReplace) {
      if (angular.isUndefined(functionHandler)) {
        return $missingTranslationHandlers[0];
      }
      $missingTranslationHandlers = [functionHandler];
    } else {
      if (!angular.isUndefined(functionHandler) && functionHandler === true) {
        return $missingTranslationHandlers;
      } else {
        $missingTranslationHandlers.push(functionHandler);
      }
    }

// supporting
function fn() {}
equals([], missingTranslationHandler(true));
equals(undefined, missingTranslationHandler());
missingTranslationHandler(fn);
equals(fn, missingTranslationHandler());
equals([fn], missingTranslationHandler(true));
missingTranslationHandler(fn, true);
equals(fn, missingTranslationHandler());
equals([fn, fn], missingTranslationHandler(true));

* 2. Just like missingTranslationHandler, but for success.*

Before:

    $rootScope.$broadcast('translationChangeSuccess');

After:

    $successTranslationChangeHandler();

(Ore even a list because we will actually relay on that broadcast).

from angular-translate.

@PascalPrecht Gotcha. Renaming a project while commenting isn't supported by Github. No redirect, only an error ;)

from angular-translate.

Oh no wait.. the mail link is broken.

from angular-translate.

This is of course a pretty cool approach of handling several handlers for errors and success, but I'm not sure if this is currently really required.

If you want to, you can go ahead and implement this in canary. Otherwise, I'd just implement something like useMissingTranslationHandle('serviceString') or so, since this is currently totally enough.

from angular-translate.

Implemented this in f6ed3e3

Will merge it into master later today. Last chance to review!

from angular-translate.

Landed in master.

from angular-translate.