Git Product home page Git Product logo

Comments (2)

macjohnny avatar macjohnny commented on May 28, 2024

@danielzen thanks for your request.

whenever an observable is subscribed to within a component, the angular-rxjs-takeuntil-before-subscribe rule ensures that there is an ngOnDestroy method

lint-rules/rules/angularRxjsTakeuntilBeforeSubscribeRule.ts

Lines 195 to 216 in eafe305

// check the ngOnDestroyMethod
const destroySubjectNamesUsedList = Object.keys(destroySubjectNamesUsed);
destroySubjectNamesUsedList.forEach(destroySubjectNameUsed => {
// look for ngOnDestroy in class and in all parent classes
const classesToCheck = [
componentClassDeclaration,
...this.findParentClasses(program, componentClassDeclaration)
];
const ngOnDestroyFailuresList = classesToCheck.map(classDeclaration => this.checkNgOnDestroy(
sourceFile,
classDeclaration,
destroySubjectNameUsed
));
// if there is no correct implementation of ngOnDestroy in any of the classes to be checked
if (ngOnDestroyFailuresList.length > 0 && !ngOnDestroyFailuresList.find(failures => failures.length === 0)) {
failures.push(...ngOnDestroyFailuresList[0]);
}
});
return failures;
}

lint-rules/rules/angularRxjsTakeuntilBeforeSubscribeRule.ts

Lines 417 to 424 in eafe305

/**
* Checks whether the class implements an ngOnDestroy method and invokes .next() on the destroy subjects
*/
private checkNgOnDestroy(
sourceFile: ts.SourceFile,
classDeclaration: ts.ClassDeclaration,
destroySubjectNameUsed: string
): Lint.RuleFailure[] {

how is your feature request different from that?

from lint-rules.

danielzen avatar danielzen commented on May 28, 2024

Not sure why it didn't work for me, but I will double check. Thanks!

from lint-rules.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.