Comments (6)
Submitted a PR:
#18
from elements.
@adickson311 but is it ? the configs are registered in the service right ? so service holds them all, and whenever we call forFeature
then we basically append the last one in the service or ?
addConfigs(newConfigs: ElementConfig[]) {
newConfigs.forEach(newConfig => {
const existingConfig = this.getElementConfig(newConfig.tag);
if (existingConfig) {
console.warn(
`${LOG_PREFIX} - ElementConfig for tag '${newConfig.tag}' was previously added, it will not be added multiple times, continue...`
);
} else {
this.configs.push(newConfig); // <--- this line
}
});
}
from elements.
@adickson311 because the constructors should happen one by one and NOT concurrently, that way we should also append configs to the service one by one and not lose anything ?
from elements.
@adickson311 the only way I could reproduce your bug is
@NgModule({
schemas: [CUSTOM_ELEMENTS_SCHEMA],
imports: [
LazyElementsModule.forFeature(options1),
LazyElementsModule.forFeature(options2),
]
})
export class ExampleModule {}
Where only the second option2
will be added, then again, does such an code make sense? It works great with single LazyElementsModule.forFeature(allFeatureOptions)
registration...
The usage of last config prevents us from adding single config multiple times because then every new feature would re-add all the previous configs (because of the multi provider) and spam user with warning like this...
@angular-extensions/elements - ElementConfig for tag 'ion-button' was previously added, it will not be added multiple times, continue...
from elements.
@adickson311 do you have any other way to reproduce this behavior ?
from elements.
@adickson311 is this still an issue?
from elements.
Related Issues (20)
- Not able to refresh/reload angular element using axLazyElement through Angular Proxy
- Using custom element inside ng-template of another custom element throws an error
- url not exist
- Request for shadow-root support
- How do i load <ax-lazy-element> dynamically using Angular dynamic component loader? HOT 1
- React version of axLazyElement
- The `isModule` property of a `ElementConfig` is ignored.
- Does v13.0.0 of this package support Angular 14? HOT 1
- How to merge source map files HOT 1
- QUESTION: Why is Intersection Observer and requestIdleCallback not used?
- Angular 15 migrations - inject() HOT 3
- Angular 15 migrations - deprecated entities HOT 2
- Angular 15 migrations - standalone components / directives / router / ...
- How to communicate the element ? HOT 1
- lazy elements module keep loading the MFE in an infinite loop. HOT 1
- axLazyElement not able to identify whether remote element is stopped or running HOT 13
- Bearer-token not propagated when resolving a web component from a different host
- HMR in Microfront
- Reload Component
- property binding to web component doesn't work as expected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elements.