Use libraries from Orbit? about tern.java HOT 17 CLOSED

Hi Mickael,

I had created those 2 projects when I started tern.java. But if you see https://github.com/angelozerr/tern.java/blob/master/pom.xml#L83 json-simple is declared in the POM.

For Rhino, compilation works because Kepler provides Rhino (but it's not the well version of Rhino,but Tern Rhino doesn't work on Eclipse IDE).

In short answer org.json.simple and org.mozilla.javascript are not used in the build maven.

from tern.java.

json-simple is declared in the POM.

Why is it so? Don't you need it at runtime? Do you need it only at compile-time?

but it's not the well version of Rhino,but Tern Rhino doesn't work on Eclipse IDE

Which version of Rhino do you need? I see Orbit does include Rhino 1.7.4 as last version.

from tern.java.

I though that declare json-simple in the POM was enough.

@pascalleclercq could you help us with this issue please? If you have time Mickael, perhaps it should be cool to create a pull request?

from tern.java.

I though that declare json-simple in the POM was enough.

I verified and apparently, there is no OSGi bundle (from Orbit nor anywhere else) for json-simple, so putting in the pom file and including it in the jar is actually one of the only and best way to consume it.

About Rhino, is the latest Rhino version on Orbit (1.7.4) ok, or do you need a newer one?

Could the Rhino and org.json.simple modules be removed?

from tern.java.

About Rhino, is the latest Rhino version on Orbit (1.7.4) ok, or do you need a newer one?

For Rhino, I use Rhino 1.7R4 which supports ECMAScript5.

Could the Rhino and org.json.simple modules be removed?

Sure, but please explain me if there is some configuration to do with maven in order to use bundle from Orbit (after your changes).

from tern.java.

Sure, but please explain me if there is some configuration to do with maven in order to use bundle from Orbit (after your changes).

Just referencing the Orbit repository similarly to https://github.com/angelozerr/tern.java/blob/master/pom.xml#L92 would be enough.

from tern.java.

Just referencing the Orbit repository similarly to https://github.com/angelozerr/tern.java/blob/master/pom.xml#L92 would be enough.

Ok do we need to install some TP to have simple-json bundle when we are on development mode?

@mickaelistria if you see #30 I will create a new plugin project.Do you wish I create it (empty project) in order to avoid changing your integration in JBoss?

from tern.java.

On 04/22/2014 02:29 PM, Angelo wrote:

Just referencing the Orbit repository similarly to
https://github.com/angelozerr/tern.java/blob/master/pom.xml#L92
would be enough.

Ok do we need to install some TP to have simple-json bundle when we
are on development mode?

No. There is actually no OSGi bundle for simple-json, so there isn't
much we can improve on that site... However, I'm not sure you need to
reference it in the parent, you probably only need it in the

@mickaelistria https://github.com/mickaelistria if you see #30
#30 I will create a
new plugin project.Do you wish I create it (empty project) in order to
avoid changing your integration in JBoss

Don't worry about our integration, we take care of it.
I'll most likely come with a pull request to suggest changes in the
tern.java repo.

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

from tern.java.

See PR #53 for a suggestion of change.

from tern.java.

I'm not a big expert with maven. Now org.json.simple project doesn't exist and I have compilation problem with it. That's why my fear (because I'm not familar with that and I had created on GitHub this project).

How to resolve this problem? Create a target platform? Create this project with maven?

Thank's for your help.

from tern.java.

On 04/24/2014 12:19 AM, Angelo wrote:

I'm not a big expert with maven. Now org.json.simple project doesn't
exist and I have compilation problem with it. That's why my fear
(because I'm not familar with that and I had created on GitHub this
project).
How to resolve this problem? Create a target platform? Create this
project with maven?

You mean you have a compilation issue in your workspace?
If so there are 2 ways to fix this:

1. Import the project (from its own SCM location) into your workspace
2. Tweak your target-platform (Preference > PDE > Target-Platform) to
   reference the OSGi artifact. (probably cleaner)

In case you need it into a p2 repo, I guess we can give you a hand and
include it into JBoss Tools Locus (which is our Orbit-like project for

JBoss Tools). Cf https://github.com/jbosstools/jbosstools-locus

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

from tern.java.

Thank's for your clarification. Perhaps I should create a thirparty folder which contains my old project json-simple and rhino to avoid users like me to have compilation troubles (I would like to avoid tweaking TP, just get sources from git)

from tern.java.

On 04/24/2014 09:14 AM, Angelo wrote:

Thank's for your clarification. Perhaps I should create a thirparty
folder which contains my old project json-simple and rhino to avoid
users like me to have compilation troubles (I would like to avoid
tweaking TP, just get sources from git)

I don't believe shipping sources of 3rd party projects is a good
practice. It makes unclear what's part of the project and what is a
dependency, and it make license tracking more complex.

The best practice IMO is to create a .target file that contains
everything user and build need to have a successful compilation, and to
tell use that in order to easily work with the project, they'd to enable
the given target-platform. If you want the target-platform to work for
both IDE and Tycho build, then all deps need to be p2 artifacts.

Or just documenting to developers where to get the 3rd party project from.

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

from tern.java.

I would like to avoid configuring something after retrieve sources from Git. I know you don't like this idea, but is it a problem for your build, that I add a new folder 'thirdparties' which contains my old project :

• core
• eclipse
• thirdparties
  • org.json.simple
  • org.mozilla.javascript
• update-site

'thirdparties' is just used for workspace compilation if you don't want to use target platform.

Are you OK with that?

from tern.java.

On 04/24/2014 10:31 AM, Angelo wrote:

I would like to avoid configuring something after retrieve sources
from Git. I know you don't like this idea, but is it a problem for
your build, that I add a new folder 'thirdparties' which contains my
old project :

'thirdparties' is just used for workspace compilation if you don't
want to use target platform.

Are you OK with that?

Well, I still believe it's an anti-pattern for a project to come with
the sources of its dependencies instead of configuring the right things
to have them available (like it can be done via dependencies in pom.xml
or .target files) or making explicit that dependencies have to be
fetched from their own source; but it doesn't prevent anyone from
consuming the project or contributing to it. So I'm not strongly against
that change ;)
By the way, I'm wondering whether using the m2e-tycho connector would be
able to add the json-simple dependency to the classpath automatically.

from tern.java.

I understand that it's an anti-pattern, but I like when it's simply. You get sources from GitHub and let's go for the contribution.

For the moment, I commit the 'thirdparties' folder which is just used for workspace compilation. In your case, please ignore this folder in your build.

from tern.java.

Let's close this one as it's now using Orbit when possible.

from tern.java.