Git Product home page Git Product logo

Comments (4)

anestisb avatar anestisb commented on June 15, 2024

By duplicate I'm guessing you mean that you have one copy under /system/lib{64} and one under /vendor/lib{64}. Is that the case?

If so, then something has been mixed in your environment since I cannot reproduce. Have a look at the following for a few builds against Angler & Bullhead:

$ find out_* -iname "libloc_api_v02.so"
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/system/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/system/lib64/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/symbols/system/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/symbols/system/lib64/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/PACKAGING/target_files_intermediates/aosp_bullhead-target_files-eng.anestisb/SYSTEM/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/PACKAGING/target_files_intermediates/aosp_bullhead-target_files-eng.anestisb/SYSTEM/lib64/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/SHARED_LIBRARIES/libloc_api_v02_intermediates/PACKED/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/SHARED_LIBRARIES/libloc_api_v02_intermediates/LINKED/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj_arm/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj_arm/SHARED_LIBRARIES/libloc_api_v02_intermediates/PACKED/libloc_api_v02.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj_arm/SHARED_LIBRARIES/libloc_api_v02_intermediates/LINKED/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/symbols/vendor/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/symbols/vendor/lib64/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib64/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_api_v02_intermediates/PACKED/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_api_v02_intermediates/LINKED/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/vendor/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/vendor/lib64/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj_arm/lib/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_api_v02_intermediates/PACKED/libloc_api_v02.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_api_v02_intermediates/LINKED/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/symbols/vendor/lib/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/symbols/vendor/lib64/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/lib/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib64/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_api_v02_intermediates/PACKED/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_api_v02_intermediates/LINKED/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/vendor/lib/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/vendor/lib64/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj_arm/lib/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_api_v02_intermediates/PACKED/libloc_api_v02.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_api_v02_intermediates/LINKED/libloc_api_v02.so
$ find out_* -iname "libloc_ds_api.so"
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/system/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/system/lib64/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/symbols/system/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/symbols/system/lib64/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/PACKAGING/target_files_intermediates/aosp_bullhead-target_files-eng.anestisb/SYSTEM/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/PACKAGING/target_files_intermediates/aosp_bullhead-target_files-eng.anestisb/SYSTEM/lib64/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/SHARED_LIBRARIES/libloc_ds_api_intermediates/PACKED/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj/SHARED_LIBRARIES/libloc_ds_api_intermediates/LINKED/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj_arm/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj_arm/SHARED_LIBRARIES/libloc_ds_api_intermediates/PACKED/libloc_ds_api.so
out_release_Linux_7.0.0_r4/aosp_prod/target/product/bullhead/obj_arm/SHARED_LIBRARIES/libloc_ds_api_intermediates/LINKED/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/symbols/vendor/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/symbols/vendor/lib64/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib64/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_ds_api_intermediates/PACKED/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_ds_api_intermediates/LINKED/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/vendor/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/vendor/lib64/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj_arm/lib/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_ds_api_intermediates/PACKED/libloc_ds_api.so
out_release_Linux_7.0.0_r6/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_ds_api_intermediates/LINKED/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/symbols/vendor/lib/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/symbols/vendor/lib64/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/lib/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/PACKAGING/target_files_intermediates/aosp_angler-target_files-eng.anestisb/VENDOR/lib64/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_ds_api_intermediates/PACKED/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj/SHARED_LIBRARIES/libloc_ds_api_intermediates/LINKED/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/vendor/lib/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/vendor/lib64/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj_arm/lib/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_ds_api_intermediates/PACKED/libloc_ds_api.so
out_userdebug_Linux_7.0.0_r9/aosp_prod/target/product/angler/obj_arm/SHARED_LIBRARIES/libloc_ds_api_intermediates/LINKED/libloc_ds_api.so

As you can see there is one copy only of the mentioned libs under /system for Bullhead and under /vendor for Angler. Also it's not possible to compile the version of these libraries available in AOSP tree since they're broken due to missing private libraries.

My best guess is that you either mixed some makefiles between the two devices and end-up with these duplicates (do a clean generate & build to confirm) or you've included some other vendor files on the top that are messing with the ones generated from the script.

At any case I cannot help much if I cannot reproduce.

from android-prepare-vendor.

Joshndroid avatar Joshndroid commented on June 15, 2024

No, when building aosp (i even checked the android git device tree) and using clean vendor, it will state that there is a duplicate module for those listed above and that it is defined within the device/huawei/angler (or device/lge/bullhead). Removing those 2 libs from vendor, OR removing the offending packages from the device tree allow build to continue and GPS function. I have had this same issue from initial vendor creation and with this lastest round of source releases a few days ago (again starting clean). Does that make more sense?

from android-prepare-vendor.

anestisb avatar anestisb commented on June 15, 2024

Ok got you now. Since the mentioned module definitions from AOSP are broken (cannot get build due to missing private library dependencies) I tried to exclude them from building without modifying any AOSP source code.

This is achieved by un-setting the BOARD_VENDOR_QCOM_GPS_LOC_API_HARDWARE variable at the generated vendor/huawei/angler/BoardConfigVendor.mk Having it empty effectively means that the AOSP sources of the same modules are never included for build due to this.

If you get a duplicate definition when makefiles are parsed prior to start building, then it means that the above mechanism is somewhere broken. You need to chase what is different in your env / process that results in both being included. I have no reports for this issue before so something in your env is triggering the problem.

From my side I can remove those two libs from having a standalone target and let them be part of the bulk PRODUCT_COPY_FILES copy, although that is not defensive enough since users will have a half broken location library for their devices being build and might possible end up with duplicate libraries if Google at some point fixes the lib deps and we don't notice in time. So I prefer to leave it as is since it's an early indicator that something is not working as expected when building.

from android-prepare-vendor.

anestisb avatar anestisb commented on June 15, 2024

Closing since it doesn't seem like an issue here. Let me know if you have new evidence that indicate otherwise.

from android-prepare-vendor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.