Allow negations in match about webpack-blocks HOT 8 CLOSED

I like it! :)

Would be happy to review a PR introducing that.

from webpack-blocks.

And thanks for sharing your idea, @marcofugaro

from webpack-blocks.

Negations can happen anywhere in a pattern, how are we going to handle it? Is it going to be predictable?
And also glob-to-regexp doesn't support many glob features including negations.

from webpack-blocks.

Negations can happen anywhere in a pattern

Really? I was thinking about the negation of the whole pattern (! in the very front) only. Just as a nicer way to specify exclusions.

And also glob-to-regexp doesn't support (...) negations

True, but could quite easily be worked around by doing this, I think:

const negations = patterns.filter(pattern => pattern.startsWith('!')).map(pattern => pattern.substr(1))
match.test = patterns.filter(pattern => !pattern.startsWith('!')).map(regexify)
match.exclude = options.exclude.concat(negations.map(regexify))

(If it starts with a !, then strip it, regexify as usual, but append to match.exclude instead of match.test)

from webpack-blocks.

Yes, I think that's it's way too much overhead to support also negations anywhere in a pattern.
Probably not worth it since negations are always used at the start.

from webpack-blocks.

By the way, @andywer do you think we still need to support the options parameter (the second one) in the match()?

from webpack-blocks.

Good question. I would keep it, since it doesn't cost us anything except maintenance of a couple of LOC. There might still be scenarios where you want to pass a more elaborate include/exclude configuration.

But no hard feelings either way.

from webpack-blocks.

Alright, done it. It was a pain to handle all the cases.

from webpack-blocks.