Git Product home page Git Product logo

Comments (3)

andrusieczko avatar andrusieczko commented on July 20, 2024

Hi @hongaar,

Oh you're right!

Apparently, the code still works as expected in most of the cases :) By coincidence.

As typeof(options.isForWebkit !== "undefined") is always true, we can ignore this condition.
Thus:

options? options.isForWebkit : this.isForWebkit

And having this.isForWebkit set by default to true, we can simplify it to:

options? options.isForWebkit : true

So isForWebkit is true unless you provide an empty map as options (or a map that doesn't include isForWebkit). Then, you'll see the error.

Thanks for spotting that typo, I wrote a test for it as well.

You can check the fixed version here:
#18

Cheers,
Karol

from clip-path-polygon.

hongaar avatar hongaar commented on July 20, 2024

👍 thanks for the quick fix!

from clip-path-polygon.

andrusieczko avatar andrusieczko commented on July 20, 2024

Ah, forgot to ask that you can get the new version (0.1.8) from either npm, bower or just download the minified file.

Thanks again,
Karol

from clip-path-polygon.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.