Comments (3)
Hi @hongaar,
Oh you're right!
Apparently, the code still works as expected in most of the cases :) By coincidence.
As typeof(options.isForWebkit !== "undefined")
is always true, we can ignore this condition.
Thus:
options? options.isForWebkit : this.isForWebkit
And having this.isForWebkit
set by default to true
, we can simplify it to:
options? options.isForWebkit : true
So isForWebkit
is true
unless you provide an empty map as options (or a map that doesn't include isForWebkit
). Then, you'll see the error.
Thanks for spotting that typo, I wrote a test for it as well.
You can check the fixed version here:
#18
Cheers,
Karol
from clip-path-polygon.
👍 thanks for the quick fix!
from clip-path-polygon.
Ah, forgot to ask that you can get the new version (0.1.8) from either npm, bower or just download the minified file.
Thanks again,
Karol
from clip-path-polygon.
Related Issues (16)
- Support different clip-paths on different elements HOT 2
- Percentages in clip-path HOT 8
- Not supporting safari 5.1 version HOT 3
- 2 polygon in the same page HOT 5
- The size of mask-of HOT 4
- Any future support for Internet Explorer or Edge browsers? HOT 5
- 401 - Unauthorized: Access is denied due to invalid credentials. HOT 3
- Bower HOT 4
- clip-path-polygon transitions HOT 9
- Value point with percentage and px HOT 2
- Generated svg add empty space after all content HOT 10
- svg display: none breaking clip in FF OSX HOT 3
- Upgrade chrome 55 breaks script HOT 1
- Webpack issue - "Critical dependency: require function is used in a way in which dependencies cannot be statically extracted" HOT 7
- Internet Explorer (IE) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clip-path-polygon.