Git Product home page Git Product logo

Comments (3)

jafu888 avatar jafu888 commented on July 16, 2024 1

ConstraintSets are not designed for frame by frame apply.
ConstraintLayout is a linear equation solver. It will be slow if you update every frame managing 28 widgets.
If you are changing visibility frequently (especially to Gone).
Reactive frameworks like compose work by doing a diff on your update.
ConstraintSet it not built that way. (And to some extent ConstraintLayout could be slow to)
You could reduce your change by using ConstraintProperties which are per view.

from constraintlayout.

jafu888 avatar jafu888 commented on July 16, 2024

I need a little more details:
I am not sure ConstraintSet.VISIBILITY_MODE_IGNORE is relevant to ConstraintLayout
What are you hoping to achieve by setting it?
Why are you maintaining the ConstraintSet?
Why

 if (isFirstRender) {
            constraintSet.setVisibility(view.id, View.GONE)
        } else {
            view.visibility = View.GONE
        }

Not

            constraintSet.setVisibility(view.id, View.GONE)
            view.visibility = View.GONE

?

from constraintlayout.

InsaneDoggo avatar InsaneDoggo commented on July 16, 2024

Yep, i didin't mention that during init i setting up relations between generated views. e.g.

constraintSet.connect(labelId, ConstraintSet.START, inputId, ConstraintSet.START)

Overall overview:
There is a virtualFlow with couple inputs in a chain, each of input has "connected" label and error TextViews.
UI is driven by state: LiveData + monolith state of whole screen which renders on every change. Current View Framework doesn't friendly for such approach so there is a lot of optimisations inside my observe function aka "render state". For example, i can "calculate diff" between old and new states and update only small part of my view tree, e.g. one input + connected label and error.
So render state will looks like:

val itemToUpdate = magicDiffAlrgorithm(state)
if (itemToUpdate.isVisible) {
   view.visibility = View.VISIBLE
} else {
   view.visibility = View.GONE
}
...
view.text = itemToUpdate.title
// and so on

In this case view.visibility = View.GONE will works fast, while constraintSet.setVisibility(view.id, View.GONE) breaks this idea due to nature of constraintSet.applyTo(..). I can't use it for frequent changes cuz it leads to performance issues.

P.S. issue partially solved by checks on false-positive updates e.g.

fun View.show(): View {
    if (visibility == View.VISIBLE) return
    visibility = View.VISIBLE
} // or similar via ConstraintSet.getVisibility(int viewId)

But it doesn't helps if you realy need to change visibility frequintly. The worst part is that i forced to use both approaches: ConstraintSet for first frame draw and eficient for rest ones.MVI

P.S. i chose such architecture with manual diffing to more seamless migration to compose wihtout diving in heavy frameworks like MVICore or Litho

image

from constraintlayout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.