Git Product home page Git Product logo

Comments (7)

fillobotto avatar fillobotto commented on June 18, 2024

Anyone?

from play-billing-samples.

gorgon avatar gorgon commented on June 18, 2024

Are you using new Play Billing library or modified TrivialDrive sample?
From what I see, they both explicitly define the package inside serviceIntent:
serviceIntent.setPackage("com.android.vending");
Maybe, it's just a side-effect of "cracking" the system? How often does it happen?

from play-billing-samples.

fillobotto avatar fillobotto commented on June 18, 2024

I am using the new library. Well, the number of crashes is low but it also happens on startup when checking purchases and it's not good that the app crashes even though the user has installed illegal software on his device. You should look into this

from play-billing-samples.

gorgon avatar gorgon commented on June 18, 2024

My guess is that hack tools sometimes are removing explicit package name from the intent on the fly and trying to represent themselves as a Play Store.
So there is not much we can do except including other explicit variables inside the intent in next library release, but they can also be removed.
I think the best solution for developers would be catch IllegalArgumentException from BillingClient.startConnection method.
And for security we strongly recommend using our backend API for all purchases verification.

from play-billing-samples.

ashughes avatar ashughes commented on June 18, 2024

FYI, while I understand why it's recommended to use the backend API for purchase verification, this only really works if the app has user sign-in and a backend.

from play-billing-samples.

fillobotto avatar fillobotto commented on June 18, 2024

@gorgon of course I am using backend verification with PHP code. I just wanted to know if there was a gentle way to solve the crash without having to catch the Exception explicitly on my side.

from play-billing-samples.

pfmaggi avatar pfmaggi commented on June 18, 2024

Thanks for reporting this.
I'm closing this issue because this forum is for issues with the sample.

Stackoverflow might be a better forum.

Please reopen if you still think this is an issue with the sample.

from play-billing-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.