New sample: mvp-dagger about architecture-samples HOT 4 CLOSED

It was forked a while ago from todo-mvp so it probably needs a git merge todo-mvp and a big conflict resolution.

Take a look at

https://github.com/googlesamples/android-architecture/tree/dev-todo-mvp-dagger/todoapp

I'd use git difftool -d origin/dev-todo-mvp-dagger -- . first, if you have a nice difftool installed like meld it will show differences. They should be as small and few as possible.

and feel free to open a PR against that branch.

The prod/mock flavors and the Injection class have to be removed from it.

from architecture-samples.

Hey @JoseAlcerreca would love to take care of this during weekend.
Are you working on it? Do not want to duplicate effort.
edit: Dagger2 ofc.

Cheers.

from architecture-samples.

Also, before committing code please highlight the changes you plan to make. Thanks!

from architecture-samples.

Hi Jose, I've built an sample weather app using MVP and Dagger2, but not sure if the mvp is structured the same way as you are planning to do.
Here is the link https://github.com/Ericliu001/Weather2016

The basic idea is to move as much business logic into presenter as possible and the View only takes care of user actions and refreshing display elements. I use a No-UI Fragment as the ViewModel because it can survive configuration changes if we set retainInstance(true).

If you feel this is the way to go, I will be working on the to-do app and create a pull-request using this structure. Thank you!

from architecture-samples.