possible to re-instate fallback if 'iconv' isn't available? about mimelib HOT 4 CLOSED

Hi,

I understand the problem, I also have had some problems with node-iconv in certain systems and if your'e always using UTF-8 then it is not needed anyway. So I changed it back.

Best regards,
Andris

On 26.05.2011, at 22:47, trentm wrote:

Back when this was just "mime.js" in the Nodemailer repo there was this for the iconv import:

try{
   // see http://github.com/bnoordhuis/node-iconv for more info
   var Iconv = require("iconv").Iconv;
}catch(E){
   // convert nothing
   Iconv = function(){}
   Iconv.prototype.convert = function(str){return str};
}

Now that is:

// see http://github.com/bnoordhuis/node-iconv for more info
var Iconv = require("iconv").Iconv;

Would it be possible/reasonable to re-instate the optional usage of iconv? Currently I want this because the node-iconv build fails for me on Solaris (I'm looking into the build failure and will report the issue to bnoordhuis/node-iconv separately). However, I could see this optional usage of iconv being useful for scenarios where using binary modules (e.g. iconv) is unwanted or problematic.

Thanks,
Trent

Reply to this email directly or view it on GitHub:
#1

from mimelib.

Thanks!

Now what I really want is a way to "npm install nodemailer --ignore-deps=iconv" ... but such an npm feature doesn't exist. I'm not sure it is reasonable to ask you to change mimelib's package.json to NOT list iconv as a dependency. The only bad result on my end is that "npm install nodemailer" attempts to build iconv and fails.

Cheers,
Trent

from mimelib.

I don't know any good solution for this. In most cases it is desirable to include iconv automatically so leaving it out from the dependencies is not a good idea.

On 26.05.2011, at 23:14, trentm wrote:

Thanks!

Now what I really want is a way to "npm install nodemailer --ignore-deps=iconv" ... but such an npm feature doesn't exist. I'm not sure it is reasonable to ask you to change mimelib's package.json to NOT list iconv as a dependency. The only bad result on my end is that "npm install nodemailer" attempts to build iconv and fails.

Cheers,
Trent

Reply to this email directly or view it on GitHub:
#1 (comment)

from mimelib.

Yes, fair enough. I think the right answer is an option on "npm install" and NOT removing the iconv dep from mimelib.

from mimelib.