Comments (4)
Hi,
I understand the problem, I also have had some problems with node-iconv in certain systems and if your'e always using UTF-8 then it is not needed anyway. So I changed it back.
Best regards,
Andris
On 26.05.2011, at 22:47, trentm wrote:
Back when this was just "mime.js" in the Nodemailer repo there was this for the iconv import:
try{ // see http://github.com/bnoordhuis/node-iconv for more info var Iconv = require("iconv").Iconv; }catch(E){ // convert nothing Iconv = function(){} Iconv.prototype.convert = function(str){return str}; }
Now that is:
// see http://github.com/bnoordhuis/node-iconv for more info var Iconv = require("iconv").Iconv;
Would it be possible/reasonable to re-instate the optional usage of iconv? Currently I want this because the node-iconv build fails for me on Solaris (I'm looking into the build failure and will report the issue to bnoordhuis/node-iconv separately). However, I could see this optional usage of iconv being useful for scenarios where using binary modules (e.g. iconv) is unwanted or problematic.
Thanks,
TrentReply to this email directly or view it on GitHub:
#1
from mimelib.
Thanks!
Now what I really want is a way to "npm install nodemailer --ignore-deps=iconv" ... but such an npm feature doesn't exist. I'm not sure it is reasonable to ask you to change mimelib's package.json to NOT list iconv as a dependency. The only bad result on my end is that "npm install nodemailer" attempts to build iconv and fails.
Cheers,
Trent
from mimelib.
I don't know any good solution for this. In most cases it is desirable to include iconv automatically so leaving it out from the dependencies is not a good idea.
On 26.05.2011, at 23:14, trentm wrote:
Thanks!
Now what I really want is a way to "npm install nodemailer --ignore-deps=iconv" ... but such an npm feature doesn't exist. I'm not sure it is reasonable to ask you to change mimelib's package.json to NOT list iconv as a dependency. The only bad result on my end is that "npm install nodemailer" attempts to build iconv and fails.
Cheers,
TrentReply to this email directly or view it on GitHub:
#1 (comment)
from mimelib.
Yes, fair enough. I think the right answer is an option on "npm install" and NOT removing the iconv dep from mimelib.
from mimelib.
Related Issues (20)
- Apostrophe throws off parseAddress HOT 4
- Incorrectly decoding quoted-printable strings HOT 1
- Incorrectly mix quoted-words and text in encodeMimeWords HOT 1
- parseMimeWords doesn't work HOT 1
- Deprecation warning on node 0.11.6 HOT 2
- isuue decoding string using decodeMimeWord function HOT 1
- encodeMimeWords missing space after ?= HOT 1
- TypeError: Object #<Object> has no method 'split' HOT 1
- decodeBase64 not work HOT 2
- parseAddresses with comma (",") in name HOT 1
- Release of new version HOT 1
- Stability. HOT 1
- decodeMimeWord does not work HOT 2
- And the license is...? HOT 5
- multipart decoding HOT 1
- Successor to mimelib HOT 3
- Line length limits for email attachments
- Please mark this module 'deprecated' on NPM as well
- Hello Andris9
- License Question HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mimelib.