Git Product home page Git Product logo

Comments (8)

andfoy avatar andfoy commented on September 6, 2024 1

I agree with @ccordoba12, there are more packages that have different package and module names, such as OpenCV:

conda install opencv -c conda-forge
import cv2

from pywinpty.

ccordoba12 avatar ccordoba12 commented on September 6, 2024

That's my take too, i.e. use pywinpty. This is also important to disambiguate the original library from its Python bindings, else things become a nightmare.

For example, we have pip install graphviz and conda install graphviz, which do different things (the first one installing the bindings and the second one the library).

from pywinpty.

andfoy avatar andfoy commented on September 6, 2024

But as winpty is a C program, I don't see why we would have any module naming ambiguity problems. I think there would be problems if the package was called winpty.

from pywinpty.

goanpeca avatar goanpeca commented on September 6, 2024

@andfoy please change the python package to pywintpty both the name and folder (module name)

from pywinpty.

andfoy avatar andfoy commented on September 6, 2024

Ok, I will do the changes. But I still think that is more intuitive to import winpty, as we're wrapping winpty library. For instance, at installation time we would execute:

pip install pywinpty

But to use it we would execute:

import winpty

from pywinpty.

ccordoba12 avatar ccordoba12 commented on September 6, 2024

It's the same with pyzmq:

pip install pyzmq
import zmq

so we have a good precedent here ;-)

from pywinpty.

goanpeca avatar goanpeca commented on September 6, 2024

@andfoy

I agree with @ccordoba12, there are more packages that have different package and module names, such as OpenCV:

conda install opencv -c conda-forge
import cv2

Is actually a bad example, cause there is no coherence on that naming.

from pywinpty.

ccordoba12 avatar ccordoba12 commented on September 6, 2024

I'm sure cv2 is the C library name. If so, it's the right thing to do :-)

from pywinpty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.