Git Product home page Git Product logo

Comments (8)

anatol avatar anatol commented on May 17, 2024 1

Booster does check root partition only. In your case you need fsck,fsck.ext4 only.

/boot partition is used before initramf enters the game. In fact, this is the partition where the kernel and booster image reside. When booster is loaded it is too late to check /boot.

from booster.

codicodi avatar codicodi commented on May 17, 2024

While compiling fsck into booster's init probably won't be easy, the 2nd, systemd based method listed in wiki appears to work just fine, as long as you pass ro kernel param

from booster.

anatol avatar anatol commented on May 17, 2024

Implementing fsck in go is definitely overkill.

I think that fsck functionality should follow configuration similar to how the emergency shell is enabled. If user adds fsck.<fs> to the image (using extra_files config option) and root filesystem type matches the <fs> part then fsck.<fs> /dev/... is called before mounting it.

This feature implementation is straight-forward and should not take much time. Though I work on a few long-overdue code refactoring to make unit-testing easier. Once it is done I'll look at the fsck feature.

from booster.

codicodi avatar codicodi commented on May 17, 2024

Sounds good!
By the way, is there a reason not to mount read-only by default? That would make systemd's fsck work out of the box.

from booster.

anatol avatar anatol commented on May 17, 2024

The only reason why booster mounts the root partition as RW by default is thats what mount() does if mountflags parameter is 0. See https://man.archlinux.org/man/mount.2

If you want to mount it as read-only then pass ro with the kernel params.

from booster.

codicodi avatar codicodi commented on May 17, 2024

Yeah, I know how this works :)
I was just wondering whether changing the default in booster would make user experience even better.

from booster.

anatol avatar anatol commented on May 17, 2024

Alright, fsck functionality is implemented now. Add fsck,fsck.$YOURFS to extra_files config option, regenerate the image and it should work.

This functionality is lightly tested. If you see any issues with it please let me know.

from booster.

meelten avatar meelten commented on May 17, 2024

Alright, fsck functionality is implemented now. Add fsck,fsck.$YOURFS to extra_files config option, regenerate the image and it should work.

This functionality is lightly tested. If you see any issues with it please let me know.

Does booster check ONLY root filesystem or all matching? I mean for example with ext4 root and FAT32 /boot should fsck,fsck.ext4,fsck.vfat be added or for ext4 only?

from booster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.