[Bug] Failed to parse Markdown file, `mdast-util-definitions` expected node about analog HOT 7 CLOSED

Yes, but the current check only considers the configuration of the markdown plugin. This example is using Starlight, and it seems that handles its own markdown config internally. I can look into improving detection to show the warning.

from analog.

This is due to a known incompatibility between Astro's Remark Shiki plugin and Zone.js. Unless another solution or workaround comes along, we'd have to wait for zoneless.

withastro/astro#8611

from analog.

Thanks @rlmestre. I thought the Astro plugin automatically warned about this?

from analog.

Hi @rlmestre @brandonroberts,
Thank you for taking care of my issue.
I am looking forward to using Angular with Astro by analog. 😁

from analog.

I opened an issue in the repo for the dependency that's causing the issue. Unfortunately, I think it's a long shot, but we'll see.

The good news is we finally have a root cause and it doesn't seem to be as big of a deal as native async/await conflicts with Zone. The bad news is we'll continue to run into packages that use async plugins or transformers causing these issues. In this case it's Starlight's expressive code.

You can disable expressive code by passing false to the property in starlight's astro.config:

import { defineConfig } from 'astro/config';
import starlight from '@astrojs/starlight';
import angular from '@analogjs/astro-angular';

export default defineConfig({
  integrations: [starlight({
     expressiveCode: false,
     ...
  })],
});

@brandonroberts do we want to add a warning and/or override for this particular one as well?

from analog.

My issue/PR were accepted, so the issue has been fixed upstream! To fix it "the right way", we need to wait for the dependency to be updated in unified and then Astro. If you want to try it now, you can override the package:

  "pnpm": {
    "overrides": {
      "trough": "2.2.0"
    }
  }

from analog.

Awesome, thanks @rlmestre!

from analog.