esum is slow about microphysics HOT 8 CLOSED

we should also try to mark this function as pure and get it inlined

from microphysics.

the esum algorithm comes from here: https://people.eecs.berkeley.edu/~jrs/papers/robustr.pdf

from microphysics.

it is also not clear if enum makes sense with just 2 numbers. Is it really better than just a + b

from microphysics.

the esum branch removes all the esum() calls with 2 elements in aprox13. This gives identical results to the original version when using test_react (as compared with fcompare). This suggests that for 2 elements, it does not matter.

The code is about 3% faster w/o the esum() on 2 elements.

I'm going to try to do a custom sum for 3 elements next.

from microphysics.

PR #65 addresses some of this

from microphysics.

should this still be open?

from microphysics.

I think it should still be open. We still have improvements we can make.

from microphysics.

Closing, I've done all I plan to do on esum at the moment -- the optimizations we've already thought of have been done, and new ones can be in a new issue.

from microphysics.