Comments (7)
zingale
commented on September 23, 2024
do we want to just change this?
from microphysics.
maxpkatz
commented on September 23, 2024
Yes.
from microphysics.
zingale
commented on September 23, 2024
interestingly, with tables, aprox13 integration with test_react does more RHS evals:
no table:
Execution time: 30.443917989730835
RHS stats:
min: 6
avg: 1522
max: 23965
tables:
Execution time: 26.683586120605469
RHS stats:
min: 6
avg: 1916
max: 46530
from microphysics.
zingale
commented on September 23, 2024
Here's the comparison for the test:
variable name absolute error relative error
(||A - B||) (||A - B||/||A||)
----------------------------------------------------------------------
level = 1
density 0.000000000 0.000000000
temperature 0.000000000 0.000000000
Xnew_helium-4 0.7446594393E-06 0.7446594402E-06
Xnew_carbon-12 0.1807416444E-06 0.5839670568E-06
Xnew_oxygen-16 0.4457918293E-06 0.7767817760E-06
Xnew_neon-20 0.1002733683E-06 0.3127164189E-06
Xnew_magnesium-24 0.7251977366E-07 0.2474042924E-06
Xnew_silicon-28 0.5241993420E-06 0.8563144416E-06
Xnew_sulfur-32 0.3410176564E-06 0.1028486974E-05
Xnew_argon-36 0.1558357633E-06 0.4576690622E-06
Xnew_calcium-40 0.6082129856E-06 0.8300185222E-06
Xnew_titanium-44 0.7081178333E-06 0.1377724014E-05
Xnew_chromium-48 0.2046546471E-06 0.5383569083E-06
Xnew_iron-52 0.5256162670E-06 0.1038257153E-05
Xnew_nickel-56 0.6329660721E-06 0.6577058145E-06
Xold_helium-4 0.000000000 0.000000000
Xold_carbon-12 0.000000000 0.000000000
Xold_oxygen-16 0.000000000 0.000000000
Xold_neon-20 0.000000000 0.000000000
Xold_magnesium-24 0.000000000 0.000000000
Xold_silicon-28 0.000000000 0.000000000
Xold_sulfur-32 0.000000000 0.000000000
Xold_argon-36 0.000000000 0.000000000
Xold_calcium-40 0.000000000 0.000000000
Xold_titanium-44 0.000000000 0.000000000
Xold_chromium-48 0.000000000 0.000000000
Xold_iron-52 0.000000000 0.000000000
Xold_nickel-56 0.000000000 0.000000000
wdot_helium-4 0.7446594393E-03 0.8290511421E-06
wdot_carbon-12 0.1807416444E-03 0.6024918215E-06
wdot_oxygen-16 0.4457918293E-03 0.1486088692E-05
wdot_neon-20 0.1002733683E-03 0.3342445927E-06
wdot_magnesium-24 0.7251977365E-04 0.2474042925E-06
wdot_silicon-28 0.5241993421E-03 0.8563144418E-06
wdot_sulfur-32 0.3410176564E-03 0.1028486975E-05
wdot_argon-36 0.1558357633E-03 0.4576690623E-06
wdot_calcium-40 0.6082129856E-03 0.8300185223E-06
wdot_titanium-44 0.7081178333E-03 0.1377724014E-05
wdot_chromium-48 0.2046546471E-03 0.5383569084E-06
wdot_iron-52 0.5256162670E-03 0.1038257153E-05
wdot_nickel-56 0.6329660721E-03 0.6577058146E-06
rho_Hnuc 0.3877592594E+22 0.8471309253E-07
from microphysics.
zingale
commented on September 23, 2024
is there a reason to do aprox13, but not aprox19 and aprox21?
Also, are the tables compatible with #56?
from microphysics.
maxpkatz
commented on September 23, 2024
is there a reason to do aprox13, but not aprox19 and aprox21?
Tabulation hasn't been implemented yet in those networks.
Also, are the tables compatible with #56?
Yes.
from microphysics.
maxpkatz
commented on September 23, 2024
Closing as resolved -- whether or not to use rate tabulation for the aprox networks is now a Microphysics-wide parameter.
from microphysics.
Related Issues (20)
- speed up chabrier1998 screening by adding `` entries HOT 3
- avoid "using namespace" in headers included by application codes HOT 1
- replace std::pow(x, N) with amrex::Math::powi<N>(x) for integer N HOT 1
- remove reinterpret_cast in rhs.H HOT 1
- use std::expected to handle burn failures? HOT 4
- Initializing pivot to zero in VODE causes out of boundary access in linpack functions HOT 7
- CUDA compilation slow after retry merge HOT 1
- try to make a ROCm big kernel reproducer HOT 8
- NSE + SDC update is missing some energy from weak interactions HOT 2
- add ideal gas EOS with tabulated mean molecular weight HOT 2
- add `-mllvm -amdgpu-function-calls=true` to CMake HIP build
- indexing issue in `is_jacobian_used()`? HOT 1
- Self-consistent NSE floating-point overflow HOT 1
- discussion: explore alternative object-oriented API
- remove NSE support from Strang
- sync self-consistent NSE update with tabular NSE HOT 4
- add second set of NSE criteria HOT 1
- change default retry tolerances to be same as normal HOT 2
- Runtime parameter docs don't include the namespace HOT 1
- consolidate subch networks HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from microphysics.