burning_cutoff_density is too high by default about maestroex HOT 7 CLOSED

One could make this argument for all the cutoff densities. Perhaps we should force the user to set these by having the default be -1, and abort if it's not set in the inputs file.

from maestroex.

I like that idea.

from maestroex.

There is base_cutoff_density, anelastic_cutoff, and burning_cutoff_density that should have this behavior. (aesthetically we should call it anelastic_cutoff_density instead) There is also a buoyancy_cutoff_factor but I think the default of 5 can be kept for that.

from maestroex.

In the original MAESTRO, the error checking to make sure the inputs files didn't have nonsensical values was in probin.template. Wondering where to put the equivalent statements in MAESTROeX. Maybe in meth_params.template at the end of read_method_params...?

from maestroex.

I'm thinking base and anelastic cutoff should be required in the inputs file. burning, if not supplied, will be set to base (this is what original MAESTRO did). Any objections? (it's easy to change later)

from maestroex.

Those sound good to me - they're the ones I had issues with for the massive star (in that I didn't realise that the cutoff parameters existed or that they were set to values that were so high for this problem).

from maestroex.

Implemented and merged in from cutoff_cleanup branch.

renname anelastic_cutoff -> anelastic_cutoff_density

require anelastic and base_cutoff_density to be supplied in the inputs file - code aborts if not supplied

burning_cutoff_density takes on the value of base_cutoff_density if not supplied in the inputs file

all inputs files updated to retain the old defaults (3.e6) if nothing was supplied

from maestroex.