Comments (2)
I've looked into this again and think I've worked out what stumped me before.
- In MAESTRO, the user-specified boundary conditions are specified in
mach_jet/multifab_physbc.f90
. This iterates over the components, calculating different boundary conditions depending on the component. - In MAESTROex, the physical boundaries are defined and filled here
MAESTROeX/Source/MaestroFillData.cpp
Lines 92 to 98 in 4dee98c
- The function that fills the boundaries is
phifill
, defined inbc_fill_nd.F90
. This function does not take the component as an argument - it receives a 3d array representing a single component.
There does not seem to be an obvious way to make phifill
aware of the index of the component. InterpFromCoarseLevel
takes this as an argument, but between that and the bit where AMReX actually calls phifill
I'm not entirely sure what happens to it.
It seems to have something to do with BndryFuncArray
: in AMReX_PhysBCFunct.cpp
, I can see that this just iterates over the components and does not pass them to the Fortran function. I think this may need to be overridden in MAESTROeX so that is possible for the Fortran function to know about the component.
from maestroex.
Fixed in #57
from maestroex.
Related Issues (20)
- deprecation warnings HOT 1
- xrb_mixed sponge seems wrong
- enthalpy_pred_type logic is wrong HOT 2
- yt load issues HOT 1
- segfaults when using init_iters > 1 HOT 6
- identical if branches in BaseStateGeometrycpp HOT 1
- burner doesn't abort if fail on GPUs HOT 1
- change the Strang burn to no longer subtract off the energy offset
- SDC no longer compiles HOT 1
- Anelastic cutoff issues in Urca sims HOT 1
- drive_initial_convection not fully implemented HOT 1
- reacting_bubble fails when run on gpu HOT 7
- base state long vs. int HOT 3
- Issues with Species Prediction at Edges HOT 10
- enthalpy_pred_types that predict T seem to be missing T on edge?
- create an `eos_rh_t` type to speed up EOS calls HOT 1
- add more problems to CI
- MAESTROeX doesn't check if cells are square
- wdconvect stopped early & segment fault on GPU HOT 6
- eliminate simple_log?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maestroex.