Git Product home page Git Product logo

Comments (2)

harpolea avatar harpolea commented on June 22, 2024

I've looked into this again and think I've worked out what stumped me before.

  • In MAESTRO, the user-specified boundary conditions are specified in mach_jet/multifab_physbc.f90. This iterates over the components, calculating different boundary conditions depending on the component.
  • In MAESTROex, the physical boundaries are defined and filled here
    PhysBCFunctMaestro cphysbc(geom[lev-1],bcs,BndryFuncArray(phifill));
    PhysBCFunctMaestro fphysbc(geom[lev ],bcs,BndryFuncArray(phifill));
    Interpolater* mapper = &cell_cons_interp;
    InterpFromCoarseLevel(mf, time, *cmf[0], srccomp, destcomp, ncomp, geom[lev-1], geom[lev],
    cphysbc, 0, fphysbc, 0, refRatio(lev-1),
    mapper, bcs, 0);
  • The function that fills the boundaries is phifill, defined in bc_fill_nd.F90. This function does not take the component as an argument - it receives a 3d array representing a single component.

There does not seem to be an obvious way to make phifill aware of the index of the component. InterpFromCoarseLevel takes this as an argument, but between that and the bit where AMReX actually calls phifill I'm not entirely sure what happens to it.

It seems to have something to do with BndryFuncArray: in AMReX_PhysBCFunct.cpp, I can see that this just iterates over the components and does not pass them to the Fortran function. I think this may need to be overridden in MAESTROeX so that is possible for the Fortran function to know about the component.

from maestroex.

harpolea avatar harpolea commented on June 22, 2024

Fixed in #57

from maestroex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.