Git Product home page Git Product logo

Comments (3)

harpolea avatar harpolea commented on September 24, 2024

I've ported over most of the unit tests from MAESTRO, however some of the unit tests do not work / report larger errors than expected:

  • test_advect reports large errors
  • test_average seems to work
  • test_basestate works for planar, however some of the other problems require spherical for DIM<3 (which MAESTROeX does not support) or require networks that are not supported by Microphysics (e.g. planar-invsq requires pphotcno)
  • test_diffusion's errors are larger than expected
  • test_eos seems to work for both gamma law and helmholtz EoS (though error in T(p,s) is a little high for helmholtz)
  • test_projection: 2d periodic is ok (errors for the nodal solver are a little high, mac solver does well), 2d wall does not work (nodal solver does not converge, mac solver has relative error > 2). 3d periodic has pretty large errors, 3d wall also does not work
  • test_react: some of the tests require networks that are not supported by Microphysics. Heating tests run, but segfaults in screen.F90 for some tests with burning (e.g. aprox13). I've ported over the python scripts for generating input (xinGen.py) and checking the consistency of output (recon.py).

from maestroex.

zingale avatar zingale commented on September 24, 2024

we believe that test_advect is okay. The relative error is not really a good measure here, since the density goes to 0, so we are dividing by very small numbers.

test_react should now be fixed now.

from maestroex.

harpolea avatar harpolea commented on September 24, 2024

test_advect fixed in d4beb4a

from maestroex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.