Comments (4)
The capability of optional argument in bind(c) routines is a Fortran 2015 feature. Some compilers might support it. Some might not.
My suggestion is create a one-cell IArrayBox and pass that in case of null mask. You can also pass an integer flag indicating whether the mask is null or not.
from maestroex.
Also note C does not support optional argument. That's why the type check tool fails.
from maestroex.
Note that after the tiling merge, the mask stuff for multilevel does not work correctly since the mask incorrectly assumes the shape of the tilebox in fortran, instead of passing in the lo/hi bounds of the entire FAB. So for example, in MaestroReact we need to fix how the mask is passed in to burner_loop(). We also need to implement Weiqun's idea above in order for this to work; otherwise there would be extra optional arguments entering for the mask lo/hi bounds.
from maestroex.
Fixed all the mask argument and made them required.
from maestroex.
Related Issues (20)
- xrb_mixed sponge seems wrong
- enthalpy_pred_type logic is wrong HOT 2
- yt load issues HOT 1
- segfaults when using init_iters > 1 HOT 6
- identical if branches in BaseStateGeometrycpp HOT 1
- burner doesn't abort if fail on GPUs HOT 1
- change the Strang burn to no longer subtract off the energy offset
- SDC no longer compiles HOT 1
- Anelastic cutoff issues in Urca sims HOT 1
- drive_initial_convection not fully implemented HOT 1
- reacting_bubble fails when run on gpu HOT 7
- base state long vs. int HOT 3
- Issues with Species Prediction at Edges HOT 10
- enthalpy_pred_types that predict T seem to be missing T on edge?
- create an `eos_rh_t` type to speed up EOS calls HOT 1
- add more problems to CI
- MAESTROeX doesn't check if cells are square
- wdconvect stopped early & segment fault on GPU HOT 10
- eliminate simple_log?
- sub_chandra Segfault after time step 1 HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maestroex.