Git Product home page Git Product logo

Comments (4)

WeiqunZhang avatar WeiqunZhang commented on September 23, 2024

The capability of optional argument in bind(c) routines is a Fortran 2015 feature. Some compilers might support it. Some might not.

My suggestion is create a one-cell IArrayBox and pass that in case of null mask. You can also pass an integer flag indicating whether the mask is null or not.

from maestroex.

WeiqunZhang avatar WeiqunZhang commented on September 23, 2024

Also note C does not support optional argument. That's why the type check tool fails.

from maestroex.

ajnonaka avatar ajnonaka commented on September 23, 2024

Note that after the tiling merge, the mask stuff for multilevel does not work correctly since the mask incorrectly assumes the shape of the tilebox in fortran, instead of passing in the lo/hi bounds of the entire FAB. So for example, in MaestroReact we need to fix how the mask is passed in to burner_loop(). We also need to implement Weiqun's idea above in order for this to work; otherwise there would be extra optional arguments entering for the mask lo/hi bounds.

from maestroex.

ajnonaka avatar ajnonaka commented on September 23, 2024

Fixed all the mask argument and made them required.

from maestroex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.