Git Product home page Git Product logo

Comments (6)

mjangda avatar mjangda commented on August 15, 2024

See #14; we weren't able to figure out the width/height for the image and omitted it. The AMP runtime does not like that.

from amp-wp.

kraftbj avatar kraftbj commented on August 15, 2024

Probably related/cause: Automattic/jetpack#2281

Looking more, IIRC, Photon doesn't natively output dims in HTML, but uses device-px.js to modify on the fly to account for Retina, etc.

from amp-wp.

mjangda avatar mjangda commented on August 15, 2024

The raw post source has the width/height attributes so something on Chris' site (likely in the_content; maybe Jetpack or another plugin?) is stripping the width/height attribute.

from amp-wp.

cfinke avatar cfinke commented on August 15, 2024

Disabling Photon did indeed make the problem go away.

from amp-wp.

kraftbj avatar kraftbj commented on August 15, 2024

Photon needs a bit of thought with the Responsive Images feature plugin merge that happened a couple of days ago and situations like this. Confirmed that Photon strips the html args, adds one for JS to hook to for dynamic recalc of dims: https://github.com/Automattic/jetpack/blob/8d1f95f0043de7d394383983842ace6f58f962c8/class.photon.php#L353

For AMP for the time being, we can remove the filtering of the content ( https://github.com/Automattic/jetpack/blob/8d1f95f0043de7d394383983842ace6f58f962c8/class.photon.php#L55 ) or force add_filter( 'jetpack_photon_skip_image', '__return_true' ); for all AMP-based images for the immediate time being to force skip Photon.

from amp-wp.

kraftbj avatar kraftbj commented on August 15, 2024

The root issue has been corrected (hopefully) in Jetpack, so let's get some Photon love back.Need to reactivate and consider a ver check for 3.8.1.
Automattic/jetpack#2281

from amp-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.