Comments (6)
See #14; we weren't able to figure out the width/height for the image and omitted it. The AMP runtime does not like that.
from amp-wp.
Probably related/cause: Automattic/jetpack#2281
Looking more, IIRC, Photon doesn't natively output dims in HTML, but uses device-px.js to modify on the fly to account for Retina, etc.
from amp-wp.
The raw post source has the width/height attributes so something on Chris' site (likely in the_content
; maybe Jetpack or another plugin?) is stripping the width/height attribute.
from amp-wp.
Disabling Photon did indeed make the problem go away.
from amp-wp.
Photon needs a bit of thought with the Responsive Images feature plugin merge that happened a couple of days ago and situations like this. Confirmed that Photon strips the html args, adds one for JS to hook to for dynamic recalc of dims: https://github.com/Automattic/jetpack/blob/8d1f95f0043de7d394383983842ace6f58f962c8/class.photon.php#L353
For AMP for the time being, we can remove the filtering of the content ( https://github.com/Automattic/jetpack/blob/8d1f95f0043de7d394383983842ace6f58f962c8/class.photon.php#L55 ) or force add_filter( 'jetpack_photon_skip_image', '__return_true' );
for all AMP-based images for the immediate time being to force skip Photon.
from amp-wp.
The root issue has been corrected (hopefully) in Jetpack, so let's get some Photon love back.Need to reactivate and consider a ver check for 3.8.1.
Automattic/jetpack#2281
from amp-wp.
Related Issues (20)
- Update `AMP_Core_Block_Handler` to handle interactivity API enabled blocks HOT 1
- Lightbox images ("Expand on click") in WordPress 6.4 is broken on AMP pages HOT 1
- Search block with "button only" configuration is broken
- The attribute 'fetchpriority' may not appear in tag 'img' HOT 3
- Feature: Adding contributors section to the README.md file. HOT 3
- Breaks image and media blocks with Gutenberg 17.3.0 and 17.4.0 HOT 3
- Update node to v20 HOT 1
- Featured image not getting shown on WhatsApp. HOT 1
- Provide means to add CSP `nonce` attributes to AMP component script tags HOT 4
- Update PHP-CSS-Parser to v8.5.0 HOT 2
- Gutenberg's validation issues with Script Modules HOT 3
- Need a wordpress hook to change the form submit-success and submit-error element templates html content before rendered. HOT 4
- AMP error: Call to a member function hasAttribute() on null (0) [Error] HOT 2
- Script output for preview is not being marked as dev mode creating validation error HOT 2
- AMP error if admin bar styles are removed HOT 3
- Remove extraneous tags from readme HOT 2
- Incorrect use of $query->get_posts(), resulting in double request processing HOT 5
- Deprecation error with PHP 8.2 HOT 1
- Checkbox icons are not properly visible HOT 3
- E2E test failure in site editor screen
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amp-wp.