Comments (4)
rcebulko
commented on May 24, 2024
1
Based on looking through the flagged PRs, it looks like they were created before reviewer assignment was enabled (or, in some cases, even implemented). Since the last 10 renovate PRs had reviewers assigned by the bot as expected, I'm closing this as Obsolete/WAI. If you notice it popping up oddly at some point in the future, feel free to re-open.
from amp-github-apps.
rsimha
commented on May 24, 2024
Here is the entire list of renovate PRs. Most of them were immediately assigned a reviewer, so it's unlikely that something fundamental is broken.
Some theories that you can eliminate:
- The PRs were created when auto-assigning of reviewers hadn't been turned on
- The PRs were created when you happened to be re-deploying owners bot
- Owners bot should listen to more PR events (rebasing a branch, force-pushing the same commits, editing the title, editing the description, etc.)
from amp-github-apps.
rcebulko
commented on May 24, 2024
PRs that were created before auto-assigning would not get assigned; this is WAI. Same thing for edits, rebases, force pushes, etc. It only assigns on PR creation
from amp-github-apps.
rsimha
commented on May 24, 2024
PRs that were created before auto-assigning would not get assigned; this is WAI
My question was more about whether this is indeed what happened in the case of those PRs, not whether this is desired behavior (which it is).
from amp-github-apps.
Related Issues (20)
- Owners bot appears to be using outdated data HOT 1
- [owners] Notify required reviewers
- Clarify how approvals affect the check's outcome (before/after the check is complete) in the resulting text
- Dependency Dashboard
- Migrate TypeScript ESLint rules to use new "naming-convention" rule
- Update PR deploy internals to work on CircleCI HOT 1
- Update test status reporting internals to work on CircleCI
- Update bundle-size internals to work on CircleCI
- Update test case reporting internals to work on CircleCI
- Update project metrics internals to work on CircleCI
- Add dist.3p/current-min/vendor/*.js to bundle size check
- Rename the default branch of this repo to `main` HOT 1
- [owners] Add a mechanism to recognize specific bot accounts as legitimate reviewers HOT 4
- Owners Bot: Comments during Draft PRs leads to noise HOT 1
- Dependency Dashboard
- Add a link in release tool
- FR: Approval should not clobber sizes
- Action Required: Fix Renovate Configuration
- This is amezing.
- Delete outdated comment when a PR update removes all notify owners
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amp-github-apps.