Git Product home page Git Product logo

Comments (4)

rcebulko avatar rcebulko commented on May 24, 2024 1

The app uses a locally checked out copy of the repo to read the OWNERS files from. It's conceivably possible to fetch a listing of all files in the repo from the GitHub API, identify OWNERS files, fetch the contents of each individually, and parse from there (while monitoring each for changes to update on), but that's not something that's currently planned.

from amp-github-apps.

rcebulko avatar rcebulko commented on May 24, 2024 1

Closing since #540 addresses some of this and makes the rest obsolete.

from amp-github-apps.

rcebulko avatar rcebulko commented on May 24, 2024

(Incomplete list of) steps to clean up startup script:

  • Check in current startup script
  • Identify which steps of the startup script are required for initialization vs. re-deploying a new version
  • Update the script to clone/pull from this repository instead of the old one living in GCP
  • Identify which environment variables are used and by what (setup, Probot, and/or the app)
  • Split into initialization and deployment scripts
  • Instead of writing PEM key to a local file and setting PRIVATE_KEY_PATH env var, echo key through base64 and set as PRIVATE_KEY env var
  • Migrate to dotenv environment configuration (if possible?)

from amp-github-apps.

danielrozenberg avatar danielrozenberg commented on May 24, 2024

Is there a specific reason why you need this to be a GCP instead of GAE instance? (which takes away 99% of the problems you're having)

from amp-github-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.