[owners] Only request reviews from members of `ampproject/reviewers-amphtml` about amp-github-apps HOT 5 CLOSED

Well...about that...

Currently the bot works by pushing to a cloud repository which is separate from this repo, which I wrote a script to do by copy-pasting from a local amp-github-apps repo to a local amp-owners-bot repo, then pushing. When you run gcloud instances reset (or something like that), it restarts the instance and runs a startup-script which is part of the GCE instance metadata and contains a combination of startup script things (logging, checking out code, installing stuff, starting node under supervisord) along will a bunch of both sensitive and standard env variables. So, GCE settings and env vars are kinda one big blob at the moment. In theory there is a metadata key-value store in GCE settings, but I'm uncertain how easy it is to access these values within the app. The first step will be to move public-safe (ie. not Oauth/API tokens and keys) to a .env file where possible, and strip the massive startup-script into smaller pieces that can be checked into the repo. As that happens, we'll have a better idea of what options are available to us re: configuration.

from amp-github-apps.

When suggesting reviewers, we should only suggest those in the ampproject/reviewers-amphtml group.

Agree, this should absolutely be the behavior.

The proposed approach sounds good in general. Re: ALLOWED_REVIEWERS_TEAM, are env variables the only means of passing data to a bot instance? Or is there an alternative way to configure an instance via, say, GCE settings?

from amp-github-apps.

Update: Created tracking issue for the configuration/deployment issues #500

from amp-github-apps.

This is implemented; closing

from amp-github-apps.

Reopening this issue based on a discussion on our team chat. Today, the following statement from the original discussion does not hold true:

When suggesting reviewers, we should only suggest those in the ampproject/reviewers-amphtml group.

Here are some ideas:

• If possible, suggested reviewer(s) will be selected from the intersection of the set of owners and the set of members of ampproject/reviewers-amphtml.
• If none of the owners are members of ampproject/reviewers-amphtml, then select an arbitrary owner. It's that owner's responsibility to add a valid reviewer. (this should be rare)

WDYT?

from amp-github-apps.