Comments (8)
rcebulko
commented on June 7, 2024
1
Currently it's linked in the bot output, but obviously that's not useful until after you've already make the changes to the owners file. I'll put together a PR adding a comment with a link to all the files.
from amp-github-apps.
rcebulko
commented on June 7, 2024
@rsimha @erwinmombay Can y'all confirm no such spec exists? If not, I'll write one up in the near future as a way to familiarize myself a bit with what features exists or are intended.
from amp-github-apps.
rsimha
commented on June 7, 2024
We have go/amp-codeowners (internal), but it doesn't contain details of the OWNERS.yaml format. Might be worth adding it to the doc while fixing this issue.
from amp-github-apps.
rcebulko
commented on June 7, 2024
SGTM
from amp-github-apps.
rcebulko
commented on June 7, 2024
Should be addressed with validation/OWNERS syntax checks in #281
from amp-github-apps.
rcebulko
commented on June 7, 2024
Related: Pull #438
from amp-github-apps.
rsimha
commented on June 7, 2024
@rcebulko I was trying to make some edits to an OWNERS.yaml file, and had to look around for a while before I could find the recommended format. Would it be possible to post a comment at the top of every OWNERS.yaml file with a link to this file?
from amp-github-apps.
rcebulko
commented on June 7, 2024
Closed with above PR
from amp-github-apps.
Related Issues (20)
- Dependency Dashboard
- Migrate TypeScript ESLint rules to use new "naming-convention" rule
- Update PR deploy internals to work on CircleCI HOT 1
- Update test status reporting internals to work on CircleCI
- Update bundle-size internals to work on CircleCI
- Update test case reporting internals to work on CircleCI
- Update project metrics internals to work on CircleCI
- Add dist.3p/current-min/vendor/*.js to bundle size check
- Rename the default branch of this repo to `main` HOT 1
- [owners] Add a mechanism to recognize specific bot accounts as legitimate reviewers HOT 4
- Owners Bot: Comments during Draft PRs leads to noise HOT 1
- Dependency Dashboard
- [release calendar] Clicking on any white box next to a release channel makes all calendar info disappear HOT 1
- [release calendar] Pop-up with additional releases sometimes gets cut off
- [release calendar] Pop-up with release info sometimes appears outside the viewport
- [release calendar] Make release calendar accessible from amp.dev
- Add a link in release tool
- [release calendar] Write unit tests
- FR: Approval should not clobber sizes
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amp-github-apps.