Git Product home page Git Product logo

Comments (3)

rsimha avatar rsimha commented on May 28, 2024

@danielrozenberg could you move the work plan to a separate comment authored by you? Right now, I'm getting notified each time the comment is edited.

from amp-github-apps.

danielrozenberg avatar danielrozenberg commented on May 28, 2024

lol sure, I'll remove it from the description and add it here:

Workplan:

  • submit and deploy #428
  • after #428 is deployed, create a PR that migrates all .br files to .json (with the proper format of course) → done at ampproject/amphtml-build-artifacts#18
  • unrollback #412
  • create a new PR that reads bundle-sizes from the .json file instead of the .br file, submit and deploy it → done at #514
  • create a PR to receive a JSON payload with multiple bundle sizes when storing → done at #515
  • once #514 and #515 are deployed, update the amphtml repo to send to the JSON payload on master builds → done at ampproject/amphtml#24955
  • do a switcharoo from /store.json to /store (both on bundle-size bot and in amphtml, make sure to keep in sync) → done at #519 and ampproject/amphtml#24958 and #523
  • start storing extensions and other runtime files for master push builds → done at ampproject/amphtml#25042
  • create a PR to receive a JSON payload with multiple bundle sizes when reporting → done at #527
  • once deployed, update the amphtml repo to report the JSON payload on pull requests → done at ampproject/amphtml#25042
  • do a switcharoo from /report.json to /report (wait at least 2 weeks before doing this, to reduce changes of errors in straggling PRs) → done at #577 and ampproject/amphtml#25276 and #584
  • delete all .br and extensionless files from https://github.com/ampproject/amphtml-build-artifacts/tree/master/bundle-size
  • decide how to report and block PRs that increase bundle size of any files other than dist/v0.js

from amp-github-apps.

danielrozenberg avatar danielrozenberg commented on May 28, 2024

Closing since the "keep track" part is done. Work continues in #617

from amp-github-apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.