Comments (3)
@danielrozenberg could you move the work plan to a separate comment authored by you? Right now, I'm getting notified each time the comment is edited.
from amp-github-apps.
lol sure, I'll remove it from the description and add it here:
Workplan:
- submit and deploy #428
- after #428 is deployed, create a PR that migrates all
.br
files to.json
(with the proper format of course) → done at ampproject/amphtml-build-artifacts#18 - unrollback #412
- create a new PR that reads bundle-sizes from the
.json
file instead of the.br
file, submit and deploy it → done at #514 - create a PR to receive a JSON payload with multiple bundle sizes when storing → done at #515
- once #514 and #515 are deployed, update the amphtml repo to send to the JSON payload on master builds → done at ampproject/amphtml#24955
- do a switcharoo from /store.json to /store (both on bundle-size bot and in amphtml, make sure to keep in sync) → done at #519 and ampproject/amphtml#24958 and #523
- start storing extensions and other runtime files for master push builds → done at ampproject/amphtml#25042
- create a PR to receive a JSON payload with multiple bundle sizes when reporting → done at #527
- once deployed, update the amphtml repo to report the JSON payload on pull requests → done at ampproject/amphtml#25042
- do a switcharoo from /report.json to /report (wait at least 2 weeks before doing this, to reduce changes of errors in straggling PRs) → done at #577 and ampproject/amphtml#25276 and #584
- delete all
.br
and extensionless files from https://github.com/ampproject/amphtml-build-artifacts/tree/master/bundle-size - decide how to report and block PRs that increase bundle size of any files other than
dist/v0.js
from amp-github-apps.
Closing since the "keep track" part is done. Work continues in #617
from amp-github-apps.
Related Issues (20)
- Dependency Dashboard
- Migrate TypeScript ESLint rules to use new "naming-convention" rule
- Update PR deploy internals to work on CircleCI HOT 1
- Update test status reporting internals to work on CircleCI
- Update bundle-size internals to work on CircleCI
- Update test case reporting internals to work on CircleCI
- Update project metrics internals to work on CircleCI
- Add dist.3p/current-min/vendor/*.js to bundle size check
- Rename the default branch of this repo to `main` HOT 1
- [owners] Add a mechanism to recognize specific bot accounts as legitimate reviewers HOT 4
- Owners Bot: Comments during Draft PRs leads to noise HOT 1
- Dependency Dashboard
- [release calendar] Clicking on any white box next to a release channel makes all calendar info disappear HOT 1
- [release calendar] Pop-up with additional releases sometimes gets cut off
- [release calendar] Pop-up with release info sometimes appears outside the viewport
- [release calendar] Make release calendar accessible from amp.dev
- Add a link in release tool
- [release calendar] Write unit tests
- FR: Approval should not clobber sizes
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amp-github-apps.