Comments (3)
@remia good catch! Nobody else caught this is the beta testing phase but it should definitely be done in a consistent space.
Like the "surround" module, the "white point sim" module is also very much a "placeholder" right now and will definitely need updating with a more robust algorithm to allow for simulation of any white point from any other white point (not just the few hard-coded options currently in there). There are comments noting this in ACESlib.OutputTransforms.ctl
. This is on the work items for a future release of ACES that more fully utilizes the parameterized output transforms.
I will review the options and push a fix to the hotfixes branch. We will then determine whether to issue a patch release or carry the fix along on the hotfixes branch for now.
from aces-dev.
Thanks @scottdyer, yes I saw the comments in the code and there is still some work to do as you say to support other whitepoint than D65 / DCI. I think there were also discussions on wether or not this adaptation needs to be dependent on the peak white luminance (current coefficients were derived for SDRs content I think ?).
I guess the compatibility issues are relatively minors because none of the existing HDR ODTs seems to be using the white point simulation transform yet.
from aces-dev.
Not that it really matter at the moment, because every HDR ODT target a D65 calibrated display, but I also noticed that in case we don't want to use the D60 simulation, a CAT from D60 to D65 is hardcoded : https://github.com/ampas/aces-dev/blob/master/transforms/ctl/lib/ACESlib.OutputTransforms.ctl#L138
from aces-dev.
Related Issues (20)
- Column title appears to be incorrectly copied from previous table HOT 1
- HLG EOTF from ITU-R BT.2100-1 is used not ITU-R BT.2100-2 HOT 2
- Order of operations for limiting to primaries and CAT causes unwanted clipping HOT 2
- Broken link in AMF README
- D65 to D60 CAT is missing from InvODT.Academy.P3DCI_D65sim_48nits.ctl
- ACES to ADX transform HOT 1
- ACEScct to ACES spec vs code discrepancy HOT 2
- ACES in Blender causes errors during .obj file import
- Many "ACEStransformID" do not honour "S-2014-002" specification. HOT 12
- Categorise the "outputTransforms" by display types. HOT 1
- Clamp in ACEScsc.ACES-to-ACEScg.ctl HOT 2
- Some CTL transform files are missing descriptions. HOT 1
- Direction comment should be removed HOT 1
- Usage comment inapplicable to inverse LMT HOT 1
- broken link on https://github.com/ampas/aces-dev/tree/dev/transforms/ctl/idt/vendorSupplied/panasonic HOT 1
- IDT "Blackmagic Film Wide Gamut (Gen 5)" does not work (wrong matrix variable) HOT 1
- Inconsistent and possibly incorrect `ACEStransformID` for ARRI LogC4 HOT 6
- Typo in DRAFT P-2013-001
- Code duplication in "ACESlib.Tonescales.ctl". HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aces-dev.