Git Product home page Git Product logo

Comments (3)

scottdyer avatar scottdyer commented on July 4, 2024

@remia good catch! Nobody else caught this is the beta testing phase but it should definitely be done in a consistent space.

Like the "surround" module, the "white point sim" module is also very much a "placeholder" right now and will definitely need updating with a more robust algorithm to allow for simulation of any white point from any other white point (not just the few hard-coded options currently in there). There are comments noting this in ACESlib.OutputTransforms.ctl. This is on the work items for a future release of ACES that more fully utilizes the parameterized output transforms.

I will review the options and push a fix to the hotfixes branch. We will then determine whether to issue a patch release or carry the fix along on the hotfixes branch for now.

from aces-dev.

remia avatar remia commented on July 4, 2024

Thanks @scottdyer, yes I saw the comments in the code and there is still some work to do as you say to support other whitepoint than D65 / DCI. I think there were also discussions on wether or not this adaptation needs to be dependent on the peak white luminance (current coefficients were derived for SDRs content I think ?).

I guess the compatibility issues are relatively minors because none of the existing HDR ODTs seems to be using the white point simulation transform yet.

from aces-dev.

remia avatar remia commented on July 4, 2024

Not that it really matter at the moment, because every HDR ODT target a D65 calibrated display, but I also noticed that in case we don't want to use the D60 simulation, a CAT from D60 to D65 is hardcoded : https://github.com/ampas/aces-dev/blob/master/transforms/ctl/lib/ACESlib.OutputTransforms.ctl#L138

from aces-dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.