Comments (3)
For what it's worth there is a rule for the react eslint that recommends using it wrapped instead of passed as a prop.
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-children-prop.md
While it may be the same thing under the hood, I agree that wrapped is a little more clear as to what's happening with the components.
from react-native-actions-sheet.
At a point I thought that too, why use children
and not just wrap everything inside the ActionSheet
. It can be done in both ways, and I have mentioned both of them in the documentation.
<ActionSheet>
<View/>
</ActionSheet>
I still think it doesnt make a difference as its possible in which ever way you like and mentioned in the docs too. what do you think?
from react-native-actions-sheet.
After a bit of research I have removed children
usage from the docs. I am closing this issue now as it has been fixed. Thanks @ncuillery and @breynolds-dev for making it clearer to me.
from react-native-actions-sheet.
Related Issues (20)
- No params passed to initial route
- No params passed to initial route
- Not working in release mode with new arch enabled (72.6) HOT 1
- [commonjs--resolver] Unexpected token => node_modules/react-native-actions-sheet/dist/src/index.js:785:12
- Uncaught TypeError: _a2.setNativeProps is not a function HOT 7
- Strange actions sheet behaviour on Android HOT 8
- How to limit max expanded height? HOT 8
- Transparent background color HOT 4
- Bottomsheet goes out of the screen in landscape mode HOT 1
- Android does not overlap the navigation bar HOT 4
- Sheet Manager does not work in react-native version 0.73.1 HOT 5
- Cannot open action sheet again when using closable={false}
- [0.9.1] closing sheet with keyboard open, resizing screens HOT 1
- Action sheet does not show 100% of the screen size. HOT 1
- 🆘 An important issue on Release Build with react-native-reanimated HOT 2
- `snapPoints` in Sheet router
- [BUG] IOS Crashes When Using this package with Webview HOT 1
- Navigating to a modal screen from action sheet causes issues in iOS with React Native 0.73 HOT 1
- [BUG] undefined value appears in the console when property animation={false} of the ActionSheet
- Is something similar to react-native's Modal presentationStyle="pageSheet" supported? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-actions-sheet.