Git Product home page Git Product logo

Comments (3)

breynolds-dev avatar breynolds-dev commented on May 11, 2024 1

For what it's worth there is a rule for the react eslint that recommends using it wrapped instead of passed as a prop.

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-children-prop.md

While it may be the same thing under the hood, I agree that wrapped is a little more clear as to what's happening with the components.

from react-native-actions-sheet.

ammarahm-ed avatar ammarahm-ed commented on May 11, 2024

At a point I thought that too, why use children and not just wrap everything inside the ActionSheet. It can be done in both ways, and I have mentioned both of them in the documentation.

<ActionSheet>
<View/>
</ActionSheet>

I still think it doesnt make a difference as its possible in which ever way you like and mentioned in the docs too. what do you think?

from react-native-actions-sheet.

ammarahm-ed avatar ammarahm-ed commented on May 11, 2024

After a bit of research I have removed children usage from the docs. I am closing this issue now as it has been fixed. Thanks @ncuillery and @breynolds-dev for making it clearer to me.

from react-native-actions-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.