Git Product home page Git Product logo

Comments (9)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
Small clarification: I was not correct about utf8: utf8 may include zero byte 
because NUL unicode codepoint is represented as zero byte in utf8. There are no 
other possible zero bytes in UTF8 (multibyte codepoints have some bits set in 
all bytes) so this is usually not an issue.

Original comment by [email protected] on 25 Aug 2012 at 8:31

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
In a Python wrapper I've resolved this by encoding <binary_value> to base64. 
Encoding/decoding speed doesn't become bottleneck (when using 
http://libb64.sourceforge.net/ decoding is orders of magnitude faster than 
Completer iteration speed).

Original comment by [email protected] on 4 Sep 2012 at 9:38

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
I'm sorry that I couldn't help you.

As you mentioned, Completer uses '\0' as the sentinel and it seems to be 
impossible to fix this without changing the structure of its auxiliary data. 
Also, the change will increase the size of the auxiliary data.

So, now I'm planning to implement a new Completer for binary keys.

Original comment by [email protected] on 7 Sep 2012 at 12:10

  • Changed state: Accepted

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
Thanks! This would be a very useful feature.

Original comment by [email protected] on 7 Sep 2012 at 12:42

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
I'm really sorry.
It has turned out that it is impossible to support binary keys without changing 
its core data structure (major update).

When I posted the last comment, I expected that dawgdic can support binary keys 
without changing Dictionary.
However, I've found that not only Completer but also Dictionary require 
modification.
In addition, the modification degrades the space efficiency and the time 
efficiency of dawgdic.
This drawback may be unacceptable.

In short, base64-encoding may support binary values better than natively 
supporting binary keys.

Original comment by [email protected] on 14 Sep 2012 at 12:16

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
Thanks for all your work on this. Binary keys would be good but base64 works 
good enough in practice. So maybe the limitation should be documented somewhere?

Original comment by [email protected] on 14 Sep 2012 at 12:20

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
Thanks for your comments.
I'll update dawgdic to reject binary keys and then update documentation.

Original comment by [email protected] on 14 Sep 2012 at 12:40

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
Looks like a good plan.

Original comment by [email protected] on 14 Sep 2012 at 12:52

from dawgdic.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 28, 2024
I've finished the update of dawgdic.
Also, the documentation has been updated.

Original comment by [email protected] on 15 Sep 2012 at 6:51

  • Changed state: WontFix

from dawgdic.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.