Decrypting crash in ios about react-native-rsa-native HOT 8 OPEN

Temporary solution ./node_modules/react-native-rsa-native/ios/RSAECNative.swift (line 370) :

from react-native-rsa-native.

added suggested fix in 2.0.5 please confirm it fixes your issue.
I haven't been working with this lib for a while so I have been maintaining it less, if anyone wants to become a maintainer please let me know

from react-native-rsa-native.

Would've been nice if this was fixed in 2.0.4. Still needs patching :/

from react-native-rsa-native.

It looks like the crash is due to decrypting a message that base 64 decodes to something longer than 256 bytes.

from react-native-rsa-native.

Yep, this still exists, If decrypting fails for some reason, the whole app is crashing (version 2.0.3):

from react-native-rsa-native.

I have the same problem too. Is there any way to verify the message before decrypting?

from react-native-rsa-native.

I hope that could be fixed too. A simple package shouldn't crash the whole app when something goes wrong. Ideally it should throw an error but even returning null would be better than nothing, since at least we can handle it.

For those searching for the issue, the error is:

Fatal error: Unexpectedly found nil while unwrapping an Optional value

Edit: In my case it was crashing using data generated from node-rsa, and I fixed it by using the "pkcs1" encryption scheme (it's "pkcs1_oaep" by default). So it looks like this:

const keys = new NodeRSA();
keys.setOptions({ encryptionScheme: 'pkcs1' });

So it seems the RN lib is making some assumption on the private key padding scheme, which unfortunately is not documented anywhere. I'd submit a PR but the repo seems pretty dead, so probably not worth it.

from react-native-rsa-native.

@ptfly it works. Thanks.

@amitaymolko
So is it possible for maintainers to fix the project?

from react-native-rsa-native.