Git Product home page Git Product logo

Comments (4)

pjsier avatar pjsier commented on July 18, 2024 1

Just created #545 if you have a second to test @sdejong629. I was able to reproduce in the unit tests and this change resolved the issue

from terraform-provider-minio.

pjsier avatar pjsier commented on July 18, 2024

Thanks for reporting this issue! It looks like this is because #526 isn't returning null for expiration. I should be able to put in a PR to fix that

from terraform-provider-minio.

sdejong629 avatar sdejong629 commented on July 18, 2024

Just created #545 if you have a second to test @sdejong629. I was able to reproduce in the unit tests and this change resolved the issue

If you have a lead on how I can use your repo instead of the registered one...

And isn't it dangerous to set an expiration date if none is set? Should it just be empty? It isn't supposed to expire items at all.

from terraform-provider-minio.

felladrin avatar felladrin commented on July 18, 2024

Thanks for the detailed report @sdejong629!

If you have a lead on how I can use your repo instead of the registered one...

To test it directly from @pjsier's branch, you can clone his repo and checkout his branch fix/543-lifecycle-days, then, having Task installed, you just need to run task install and the provider should be ready to be used (terraform gives preference to locally installed providers).

isn't it dangerous to set an expiration date if none is set? Should it just be empty? It isn't supposed to expire items at all.

🤔 As I see @pjsier's change is not for setting a date if it's empty. Instead, it's to format the Date field of Expiration in the format "YYYY-MM-DD" only if Expiration is not null. Because if we apply fortmat in a null value, it sets the expiration date to 0001-01-01, causing this bug.

from terraform-provider-minio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.