Comments (7)
If the simulation starts at initial time t = -1 and the event fires at t = 0, does everything work properly?
from amici.
Okay, I just checked and even of the initial time is negative the simulation results are different (= incorrect).
from amici.
t0 is passed at simulation time which makes this problem a bit hard to tackle but the check is currently performed at compile time. At the moment it should not be possible to define an event which fires at t=0.
from amici.
the model with heaviside(t) compiled without error (Version from 5 days ago). Only the simulation was completely off compared to heaviside(t-1e-8).
from amici.
I cannot reproduce :( that problem. For me any model with heaviside(t)
fails in makeEvents and produces the following error:
The trigger of event 1 fires at initial timepoint t0 = 0, which is currently not supported.
which version of MATLAB are you using? maybe this is a problem with the symbolic toolbox.
from amici.
My fault. I compiled wit heaviside(t-k) and set later the input k = 0. This compiles (as no k is specified) but provides later an incorrect solution.
from amici.
okay I implemented the check at run-time, which means the model can now always be compiled and simulation will always be stoppend when started in a root. This could be extended in the future to automatically check in which the crossing is, but I really do not see a good reason to start a simulation in an event. (Also this can always be fixed by the user by specifying an earlier t0).
from amici.
Related Issues (20)
- Combine `get_{expressions,observables,states,...}_as_dataframe`? HOT 1
- cmake: set sundials path hint for python package
- Remove autodoc hooks for signature/docstring processing
- sphinx fails with AttributeError: module 'sphinx.domains.cpp' has no attribute 'ASTParametersQualifiers'
- SetuptoolsDeprecationWarning: Customization incompatible with editable install HOT 1
- Remove wurlitzer dependency
- zip(... , strict=True)
- macos-latest tests failing since last night HOT 1
- InitialAssignment issue HOT 6
- Support event-assignments to compartments
- Incorrect handling of event assignments to compartments
- SBML import ignores `useValuesFromTriggerTime` attribute on events
- Execution of multiple event assignments from the same event HOT 3
- Not installing on Mac M1 HOT 4
- Compilation fails with Intel OneApi MKL 2024.1 HOT 2
- IMPORTED_LOCATION not set for imported target "Upstream::amici" HOT 1
- `Benchmark Collection` workflow fails for Lang_PLOSComputBiol2024 HOT 2
- cmake: replace explicit checks for CMAKE_BUILD_TYPE
- TimeCourse Implementation
- Piecewise function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amici.