Git Product home page Git Product logo

Comments (6)

dirk-thomas avatar dirk-thomas commented on August 20, 2024

It would definitely be good if this CMake function would have an option to choose the install destination of the executables (either bin or lib/<pkgname>). For ROS packages the second option looks like the better default, too. If we want to keep the default in this package as bin we could also introduce a ROS specific package (like ament_cmake_ros) but I don't feel strongly about a separate package for this.

from ament_cmake.

dhood avatar dhood commented on August 20, 2024

ok, so how about we change the default for executables to lib/${PROJECT_NAME} and provide and option called INSTALL_TO_PATH or something that installs executables how they are installed currently?

from ament_cmake.

dhood avatar dhood commented on August 20, 2024

Ah, I noticed in the FHS standard that "Applications may use a single subdirectory under /usr/lib. If an application uses a subdirectory, all architecture-dependent data exclusively used by the application must be placed within that subdirectory."

Does this then mean that if the executables are being installed to lib/${PROJECT_NAME}, the libraries should be installed there too? This is not consistent with how we've been changing things for other ROS 2 packages so I may have misinterpreted 'exclusively used by the application'.

from ament_cmake.

dirk-thomas avatar dirk-thomas commented on August 20, 2024

Libraries should still go into lib. This is how we do it in ROS 1 and I don't think we should change that.

from ament_cmake.

wjwwood avatar wjwwood commented on August 20, 2024

Ah, I noticed in the FHS standard that "Applications may use a single subdirectory under /usr/lib. If an application uses a subdirectory, all architecture-dependent data exclusively used by the application must be placed within that subdirectory."

I think the key word there is "exclusively", so if you have a shared library that only your application uses, it would be put there. Since we mostly make things that could be reused by other packages, those shared libraries still belong in the top-level lib. At least that's how I interpret it.

from ament_cmake.

dhood avatar dhood commented on August 20, 2024

closed bu #97, thanks @wjwwood and @dirk-thomas for the input

from ament_cmake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.